diff --git a/pkg/kubelet/cm/cgroup_manager_linux.go b/pkg/kubelet/cm/cgroup_manager_linux.go index d5fd2e48973..b5bf46941f6 100644 --- a/pkg/kubelet/cm/cgroup_manager_linux.go +++ b/pkg/kubelet/cm/cgroup_manager_linux.go @@ -31,6 +31,7 @@ import ( cgroupfs2 "github.com/opencontainers/runc/libcontainer/cgroups/fs2" cgroupsystemd "github.com/opencontainers/runc/libcontainer/cgroups/systemd" libcontainerconfigs "github.com/opencontainers/runc/libcontainer/configs" + libcontainerdevices "github.com/opencontainers/runc/libcontainer/devices" "k8s.io/klog/v2" v1helper "k8s.io/kubernetes/pkg/apis/core/v1/helper" @@ -468,13 +469,13 @@ func setResourcesV2(cgroupConfig *libcontainerconfigs.Cgroup) error { if err := propagateControllers(cgroupConfig.Path); err != nil { return err } - cgroupConfig.Resources.Devices = []*libcontainerconfigs.DeviceRule{ + cgroupConfig.Resources.Devices = []*libcontainerdevices.Rule{ { Type: 'a', Permissions: "rwm", Allow: true, - Minor: libcontainerconfigs.Wildcard, - Major: libcontainerconfigs.Wildcard, + Minor: libcontainerdevices.Wildcard, + Major: libcontainerdevices.Wildcard, }, } cgroupConfig.Resources.SkipDevices = true @@ -499,13 +500,13 @@ func setResourcesV2(cgroupConfig *libcontainerconfigs.Cgroup) error { func (m *cgroupManagerImpl) toResources(resourceConfig *ResourceConfig) *libcontainerconfigs.Resources { resources := &libcontainerconfigs.Resources{ - Devices: []*libcontainerconfigs.DeviceRule{ + Devices: []*libcontainerdevices.Rule{ { Type: 'a', Permissions: "rwm", Allow: true, - Minor: libcontainerconfigs.Wildcard, - Major: libcontainerconfigs.Wildcard, + Minor: libcontainerdevices.Wildcard, + Major: libcontainerdevices.Wildcard, }, }, SkipDevices: true, diff --git a/pkg/kubelet/cm/container_manager_linux.go b/pkg/kubelet/cm/container_manager_linux.go index e6e16ace516..c662db44c81 100644 --- a/pkg/kubelet/cm/container_manager_linux.go +++ b/pkg/kubelet/cm/container_manager_linux.go @@ -38,6 +38,7 @@ import ( utilio "k8s.io/utils/io" utilpath "k8s.io/utils/path" + libcontainerdevices "github.com/opencontainers/runc/libcontainer/devices" v1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/api/resource" utilerrors "k8s.io/apimachinery/pkg/util/errors" @@ -392,13 +393,13 @@ func createManager(containerName string) (cgroups.Manager, error) { Parent: "/", Name: containerName, Resources: &configs.Resources{ - Devices: []*configs.DeviceRule{ + Devices: []*libcontainerdevices.Rule{ { Type: 'a', Permissions: "rwm", Allow: true, - Minor: configs.Wildcard, - Major: configs.Wildcard, + Minor: libcontainerdevices.Wildcard, + Major: libcontainerdevices.Wildcard, }, }, SkipDevices: true, diff --git a/pkg/kubelet/dockershim/cm/container_manager_linux.go b/pkg/kubelet/dockershim/cm/container_manager_linux.go index 6e4db6555a1..f515a5bfb25 100644 --- a/pkg/kubelet/dockershim/cm/container_manager_linux.go +++ b/pkg/kubelet/dockershim/cm/container_manager_linux.go @@ -28,6 +28,7 @@ import ( "github.com/opencontainers/runc/libcontainer/cgroups" cgroupfs "github.com/opencontainers/runc/libcontainer/cgroups/fs" "github.com/opencontainers/runc/libcontainer/configs" + libcontainerdevices "github.com/opencontainers/runc/libcontainer/devices" utilversion "k8s.io/apimachinery/pkg/util/version" "k8s.io/apimachinery/pkg/util/wait" "k8s.io/klog/v2" @@ -126,10 +127,10 @@ func createCgroupManager(name string) (cgroups.Manager, error) { Memory: int64(memoryLimit), MemorySwap: -1, SkipDevices: true, - Devices: []*configs.DeviceRule{ + Devices: []*libcontainerdevices.Rule{ { - Minor: configs.Wildcard, - Major: configs.Wildcard, + Minor: libcontainerdevices.Wildcard, + Major: libcontainerdevices.Wildcard, Type: 'a', Permissions: "rwm", Allow: true, diff --git a/pkg/kubelet/dockershim/libdocker/kube_docker_client.go b/pkg/kubelet/dockershim/libdocker/kube_docker_client.go index 81b6582e2bc..3dfe4cf0145 100644 --- a/pkg/kubelet/dockershim/libdocker/kube_docker_client.go +++ b/pkg/kubelet/dockershim/libdocker/kube_docker_client.go @@ -145,7 +145,7 @@ func (d *kubeDockerClient) CreateContainer(opts dockertypes.ContainerCreateConfi if opts.HostConfig != nil && opts.HostConfig.ShmSize <= 0 { opts.HostConfig.ShmSize = defaultShmSize } - createResp, err := d.client.ContainerCreate(ctx, opts.Config, opts.HostConfig, opts.NetworkingConfig, opts.Name) + createResp, err := d.client.ContainerCreate(ctx, opts.Config, opts.HostConfig, opts.NetworkingConfig, nil, opts.Name) if ctxErr := contextError(ctx); ctxErr != nil { return nil, ctxErr }