github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 14:07:14 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #52161 from CaoShuFeng/kubectl_cp

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 52109, 52235, 51809, 52161, 50080). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..

Allow kubectl cp large amounts of files from container

When we try to copy out a dir with large amounts of files from container, we hit such error:

```bash
kubectl cp  mypod:/ ./a/
tar: Removing leading `/' from member names
tar: Removing leading `/' from hard link targets
error: open a/usr/share/zoneinfo/Asia/Rangoon: too many open files
```

This is because kubectl opens too many files at the same. We should close them after Write() function.
**Release note**:
```
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2017-09-23 10:26:52 -07:00 committed by GitHub
commit 90a4ac03dc
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/kubectl/cmd/cp.go
View File

@ -259,8 +259,12 @@ func untarAll(reader io.Reader, destFile, prefix string) error {
if err != nil { if err != nil {
return err return err
} }
defer outFile.Close() if _, err := io.Copy(outFile, tarReader); err != nil {
io.Copy(outFile, tarReader) return err
}
if err := outFile.Close(); err != nil {
return err
}
} }
return nil return nil
} }