github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 19:31:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #100964 from njuptlzf/SelectionPredicateUT

Browse Source 
Add more unit tests for SelectionPredicate
This commit is contained in:
Kubernetes Prow Robot 2021-04-20 23:24:10 -07:00 committed by GitHub
commit 90e599f56a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 85 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
staging/src/k8s.io/apiserver/pkg/storage/selection_predicate_test.go
View File

@ -18,6 +18,7 @@ package storage
import (
"errors"
"reflect"
"testing"
"k8s.io/apimachinery/pkg/fields"
@ -112,6 +113,10 @@ func TestSelectionPredicate(t *testing.T) {
if e, a := item.shouldMatch, got; e != a {
t.Errorf("%v: expected %v, got %v", name, e, a)
}
got = sp.MatchesObjectAttributes(item.labels, item.fields)
if e, a := item.shouldMatch, got; e != a {
t.Errorf("%v: expected %v, got %v", name, e, a)
}
if key := item.matchSingleKey; key != "" {
got, ok := sp.MatchesSingle()
if !ok {
@ -123,3 +128,83 @@ func TestSelectionPredicate(t *testing.T) {
}
}
}
func TestSelectionPredicateMatcherIndex(t *testing.T) {
testCases := map[string]struct {
labelSelector, fieldSelector string
indexLabels []string
indexFields []string
expected []MatchValue
}{
"Match nil": {
labelSelector: "name=foo",
fieldSelector: "uid=12345",
indexLabels: []string{"bar"},
indexFields: []string{},
expected: nil,
},
"Match field": {
labelSelector: "name=foo",
fieldSelector: "uid=12345",
indexLabels: []string{},
indexFields: []string{"uid"},
expected: []MatchValue{{IndexName: FieldIndex("uid"), Value: "12345"}},
},
"Match label": {
labelSelector: "name=foo",
fieldSelector: "uid=12345",
indexLabels: []string{"name"},
indexFields: []string{},
expected: []MatchValue{{IndexName: LabelIndex("name"), Value: "foo"}},
},
"Match field and label": {
labelSelector: "name=foo",
fieldSelector: "uid=12345",
indexLabels: []string{"name"},
indexFields: []string{"uid"},
expected: []MatchValue{{IndexName: FieldIndex("uid"), Value: "12345"}, {IndexName: LabelIndex("name"), Value: "foo"}},
},
"Negative match field and label": {
labelSelector: "name!=foo",
fieldSelector: "uid!=12345",
indexLabels: []string{"name"},
indexFields: []string{"uid"},
expected: nil,
},
"Negative match field and match label": {
labelSelector: "name=foo",
fieldSelector: "uid!=12345",
indexLabels: []string{"name"},
indexFields: []string{"uid"},
expected: []MatchValue{{IndexName: LabelIndex("name"), Value: "foo"}},
},
"Negative match label and match field": {
labelSelector: "name!=foo",
fieldSelector: "uid=12345",
indexLabels: []string{"name"},
indexFields: []string{"uid"},
expected: []MatchValue{{IndexName: FieldIndex("uid"), Value: "12345"}},
},
}
for name, testCase := range testCases {
parsedLabel, err := labels.Parse(testCase.labelSelector)
if err != nil {
panic(err)
}
parsedField, err := fields.ParseSelector(testCase.fieldSelector)
if err != nil {
panic(err)
}
sp := &SelectionPredicate{
Label: parsedLabel,
Field: parsedField,
IndexLabels: testCase.indexLabels,
IndexFields: testCase.indexFields,
}
actual := sp.MatcherIndex()
if !reflect.DeepEqual(testCase.expected, actual) {
t.Errorf("%v: expected %v, got %v", name, testCase.expected, actual)
}
}
}