From 5ccc6d2727145a36c06e502758c5957d96491b3b Mon Sep 17 00:00:00 2001 From: Michail Kargakis Date: Mon, 30 Jan 2017 11:35:59 +0100 Subject: [PATCH] controller: don't run informers in unit tests when unnecessary --- .../deployment/deployment_controller_test.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/pkg/controller/deployment/deployment_controller_test.go b/pkg/controller/deployment/deployment_controller_test.go index 7160ef42a28..7699fc3ecbf 100644 --- a/pkg/controller/deployment/deployment_controller_test.go +++ b/pkg/controller/deployment/deployment_controller_test.go @@ -497,16 +497,13 @@ func TestPodDeletionEnqueuesRecreateDeployment(t *testing.T) { f.rsLister = append(f.rsLister, rs) f.objects = append(f.objects, foo, rs) - c, informers := f.newController() + c, _ := f.newController() enqueued := false c.enqueueDeployment = func(d *extensions.Deployment) { if d.Name == "foo" { enqueued = true } } - stopCh := make(chan struct{}) - defer close(stopCh) - informers.Start(stopCh) c.deletePod(pod) @@ -532,16 +529,13 @@ func TestPodDeletionDoesntEnqueueRecreateDeployment(t *testing.T) { // return a non-empty list. f.podLister = append(f.podLister, pod) - c, informers := f.newController() + c, _ := f.newController() enqueued := false c.enqueueDeployment = func(d *extensions.Deployment) { if d.Name == "foo" { enqueued = true } } - stopCh := make(chan struct{}) - defer close(stopCh) - informers.Start(stopCh) c.deletePod(pod)