From 91a87aa690abf9744099d522845a39012b6c1022 Mon Sep 17 00:00:00 2001 From: andyzhangx Date: Tue, 2 Jun 2020 13:02:26 +0000 Subject: [PATCH] fix: remove unnecessary readlink check in IsLikelyNotMountPoint on Windows fix build failure fix comments fix build failure fix comments --- mount_windows.go | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/mount_windows.go b/mount_windows.go index cf419b34942..ae3c52267de 100644 --- a/mount_windows.go +++ b/mount_windows.go @@ -27,7 +27,6 @@ import ( "k8s.io/klog/v2" "k8s.io/utils/keymutex" - utilpath "k8s.io/utils/path" ) // Mounter provides the default implementation of mount.Interface @@ -182,19 +181,10 @@ func (mounter *Mounter) IsLikelyNotMountPoint(file string) (bool, error) { if err != nil { return true, err } - // If current file is a symlink, then it is a mountpoint. - if stat.Mode()&os.ModeSymlink != 0 { - target, err := os.Readlink(file) - if err != nil { - return true, fmt.Errorf("readlink error: %v", err) - } - exists, err := utilpath.Exists(utilpath.CheckFollowSymlink, target) - if err != nil { - return true, err - } - return !exists, nil - } + if stat.Mode()&os.ModeSymlink != 0 { + return false, err + } return true, nil }