github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-04 09:49:50 +00:00
Code Issues Projects Releases Wiki Activity

stop spamming logs on restart of api server

Browse Source
This commit is contained in:
Derek Carr 2017-02-27 13:18:54 -05:00
parent 7f626cf836
commit 9211e0380f
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
staging/src/k8s.io/apiserver/pkg/storage/etcd/etcd_helper.go
View File

@ -380,11 +380,12 @@ func (h *etcdHelper) decodeNodeList(nodes []*etcd.Node, filter storage.FilterFun
} }
for _, node := range nodes { for _, node := range nodes {
if node.Dir { if node.Dir {
trace.Step("Decoding dir " + node.Key + " START") // IMPORTANT: do not log each key as a discrete step in the trace log
// as it produces an immense amount of log spam when there is a large
// amount of content in the list.
if err := h.decodeNodeList(node.Nodes, filter, slicePtr); err != nil { if err := h.decodeNodeList(node.Nodes, filter, slicePtr); err != nil {
return err return err
} }
trace.Step("Decoding dir " + node.Key + " END")
continue continue
} }
if obj, found := h.getFromCache(node.ModifiedIndex, filter); found { if obj, found := h.getFromCache(node.ModifiedIndex, filter); found {

2
staging/src/k8s.io/apiserver/pkg/util/trace/trace.go
View File

@ -57,7 +57,7 @@ func (t *Trace) Log() {
buffer.WriteString(fmt.Sprintf("[%v] [%v] %v\n", step.stepTime.Sub(t.startTime), step.stepTime.Sub(lastStepTime), step.msg)) buffer.WriteString(fmt.Sprintf("[%v] [%v] %v\n", step.stepTime.Sub(t.startTime), step.stepTime.Sub(lastStepTime), step.msg))
lastStepTime = step.stepTime lastStepTime = step.stepTime
} }
buffer.WriteString(fmt.Sprintf("[%v] [%v] END\n", endTime.Sub(t.startTime), endTime.Sub(lastStepTime))) buffer.WriteString(fmt.Sprintf("%q [%v] [%v] END\n", t.name, endTime.Sub(t.startTime), endTime.Sub(lastStepTime)))
glog.Info(buffer.String()) glog.Info(buffer.String())
} }