From 3edae95e5ae3d9188831dee14c1019f250ca98bf Mon Sep 17 00:00:00 2001 From: Sascha Grunert Date: Tue, 15 Aug 2023 12:17:26 +0200 Subject: [PATCH] Add unit tests for subdomain match in keyring This ensures that the amount of subdomains should always match the glob+dot (`*.`) pattern. Refers to https://github.com/kubernetes/kubernetes/issues/119941 Signed-off-by: Sascha Grunert --- pkg/credentialprovider/keyring_test.go | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/pkg/credentialprovider/keyring_test.go b/pkg/credentialprovider/keyring_test.go index 07a63baa45a..8535a7b7271 100644 --- a/pkg/credentialprovider/keyring_test.go +++ b/pkg/credentialprovider/keyring_test.go @@ -88,6 +88,22 @@ func TestURLsMatch(t *testing.T) { targetURL: "kubernetes.io", matchExpected: false, }, + { + globURL: "*kubernetes.io", + targetURL: "a.kubernetes.io", + matchExpected: false, + }, + // match when number of parts match + { + globURL: "*kubernetes.io", + targetURL: "kubernetes.io", + matchExpected: true, + }, + { + globURL: "*.*.*.kubernetes.io", + targetURL: "a.b.c.kubernetes.io", + matchExpected: true, + }, // no match when some parts mismatch { globURL: "kubernetes.io",