From 92bac8afc190fe9a8e133099d5df01e933630ab9 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Mon, 8 Feb 2021 20:20:25 +0100 Subject: [PATCH] mock driver: fix no-op setDefaultCreds The function must modify the content of the "creds" pointer, not the pointer. Found via hack/verify-staticcheck.sh after importing the code into Kubernetes. It is uncertain whether this bug had any consequences. --- test/e2e/storage/drivers/csi-test/driver/driver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/storage/drivers/csi-test/driver/driver.go b/test/e2e/storage/drivers/csi-test/driver/driver.go index de6c06e164a..0a61ae7c48e 100644 --- a/test/e2e/storage/drivers/csi-test/driver/driver.go +++ b/test/e2e/storage/drivers/csi-test/driver/driver.go @@ -174,7 +174,7 @@ func stop(lock *sync.Mutex, wg *sync.WaitGroup, server *grpc.Server, running boo // setDefaultCreds sets the default credentials, given a CSICreds instance. func setDefaultCreds(creds *CSICreds) { - creds = &CSICreds{ + *creds = CSICreds{ CreateVolumeSecret: "secretval1", DeleteVolumeSecret: "secretval2", ControllerPublishVolumeSecret: "secretval3",