github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-08 04:32:37 +00:00
Code Issues Projects Releases Wiki Activity

refactor AddToNodeAddresses test to use t.Run and include description

Browse Source
This commit is contained in:
Andrew Kim
2019-02-01 14:55:25 -05:00
parent 369fd95a9f
commit 92e8b5b953
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
staging/src/k8s.io/cloud-provider/node/helpers/address_test.go
View File

@@ -25,16 +25,19 @@ import (
func TestAddToNodeAddresses(t *testing.T) { func TestAddToNodeAddresses(t *testing.T) {
testCases := []struct { testCases := []struct {
name string
existing []v1.NodeAddress existing []v1.NodeAddress
toAdd []v1.NodeAddress toAdd []v1.NodeAddress
expected []v1.NodeAddress expected []v1.NodeAddress
}{ }{
{ {
name: "add no addresses to empty node addresses",
existing: []v1.NodeAddress{}, existing: []v1.NodeAddress{},
toAdd: []v1.NodeAddress{}, toAdd: []v1.NodeAddress{},
expected: []v1.NodeAddress{}, expected: []v1.NodeAddress{},
}, },
{ {
name: "add new node addresses to empty existing addresses",
existing: []v1.NodeAddress{}, existing: []v1.NodeAddress{},
toAdd: []v1.NodeAddress{ toAdd: []v1.NodeAddress{
{Type: v1.NodeExternalIP, Address: "1.1.1.1"}, {Type: v1.NodeExternalIP, Address: "1.1.1.1"},
@@ -46,6 +49,7 @@ func TestAddToNodeAddresses(t *testing.T) {
}, },
}, },
{ {
name: "add a duplicate node address",
existing: []v1.NodeAddress{}, existing: []v1.NodeAddress{},
toAdd: []v1.NodeAddress{ toAdd: []v1.NodeAddress{
{Type: v1.NodeExternalIP, Address: "1.1.1.1"}, {Type: v1.NodeExternalIP, Address: "1.1.1.1"},
@@ -56,6 +60,7 @@ func TestAddToNodeAddresses(t *testing.T) {
}, },
}, },
{ {
name: "add 1 new and 1 duplicate address",
existing: []v1.NodeAddress{ existing: []v1.NodeAddress{
{Type: v1.NodeExternalIP, Address: "1.1.1.1"}, {Type: v1.NodeExternalIP, Address: "1.1.1.1"},
{Type: v1.NodeInternalIP, Address: "10.1.1.1"}, {Type: v1.NodeInternalIP, Address: "10.1.1.1"},
@@ -72,10 +77,12 @@ func TestAddToNodeAddresses(t *testing.T) {
}, },
} }
for i, tc := range testCases { for _, tc := range testCases {
AddToNodeAddresses(&tc.existing, tc.toAdd...) t.Run(tc.name, func(t *testing.T) {
if !apiequality.Semantic.DeepEqual(tc.expected, tc.existing) { AddToNodeAddresses(&tc.existing, tc.toAdd...)
t.Errorf("case[%d], expected: %v, got: %v", i, tc.expected, tc.existing) if !apiequality.Semantic.DeepEqual(tc.expected, tc.existing) {
} t.Errorf("expected: %v, got: %v", tc.expected, tc.existing)
}
})
} }
} }