Merge pull request #113452 from brianpursley/DBG2

Allow DBG=1 to be used with make release-images and make quick-release-images
This commit is contained in:
Kubernetes Prow Robot 2022-11-01 19:59:30 -07:00 committed by GitHub
commit 9313a1f2a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions

View File

@ -37,7 +37,7 @@ fi
kube::build::verify_prereqs
kube::build::build_image
kube::build::run_build_command make all WHAT="${CMD_TARGETS}" KUBE_BUILD_PLATFORMS="${KUBE_SERVER_PLATFORMS[*]}"
kube::build::run_build_command make all WHAT="${CMD_TARGETS}" KUBE_BUILD_PLATFORMS="${KUBE_SERVER_PLATFORMS[*]}" DBG="${DBG:-}"
kube::build::copy_output

View File

@ -380,9 +380,14 @@ define RELEASE_IMAGES_HELP_INFO
#
# Args:
# KUBE_BUILD_CONFORMANCE: Whether to build conformance testing image as well. Set to 'n' to skip.
# DBG: If set to "1", build with optimizations disabled for easier debugging. Any other value is ignored.
#
# Example:
# make release-images
# make release-images DBG=1
# Note: Specify DBG=1 for building unstripped binaries, which allows you to use code debugging
# tools like delve. When DBG is unspecified, it defaults to "-s -w" which strips debug
# information.
endef
.PHONY: release-images
ifeq ($(PRINT_HELP),y)
@ -424,9 +429,14 @@ define QUICK_RELEASE_IMAGES_HELP_INFO
# Args:
# KUBE_FASTBUILD: Whether to cross-compile for other architectures. Set to 'false' to do so.
# KUBE_BUILD_CONFORMANCE: Whether to build conformance testing image as well. Set to 'y' to do so.
# DBG: If set to "1", build with optimizations disabled for easier debugging. Any other value is ignored.
#
# Example:
# make quick-release-images
# make quick-release-images DBG=1
# Note: Specify DBG=1 for building unstripped binaries, which allows you to use code debugging
# tools like delve. When DBG is unspecified, it defaults to "-s -w" which strips debug
# information.
endef
.PHONY: quick-release-images
ifeq ($(PRINT_HELP),y)