From 5a046a4fd9363fa8983e2c8a2e762b1751a9ac04 Mon Sep 17 00:00:00 2001
From: Tomas Tormo <tomas.tormo@nearform.com>
Date: Thu, 11 Jul 2024 11:50:45 +0000
Subject: [PATCH] job_controller: Add test for SuccessCriteriaMet=False

---
 pkg/controller/job/job_controller_test.go | 34 +++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/pkg/controller/job/job_controller_test.go b/pkg/controller/job/job_controller_test.go
index 58b9c9ca3b3..172e5b700a5 100644
--- a/pkg/controller/job/job_controller_test.go
+++ b/pkg/controller/job/job_controller_test.go
@@ -291,6 +291,7 @@ func TestControllerSyncJob(t *testing.T) {
 		podIndexLabelDisabled   bool
 		jobPodReplacementPolicy bool
 		jobPodFailurePolicy     bool
+		jobSuccessPolicy        bool
 	}{
 		"job start": {
 			parallelism:       2,
@@ -1187,6 +1188,38 @@ func TestControllerSyncJob(t *testing.T) {
 				},
 			},
 		},
+		"SuccessCriteriaMet=False condition added manually is ignored": {
+			jobSuccessPolicy: true,
+			parallelism:      1,
+			completions:      1,
+			activePods:       1,
+			readyPods:        1,
+			initialStatus: &jobInitialStatus{
+				active: 1,
+				startTime: func() *time.Time {
+					now := time.Now()
+					return &now
+				}(),
+				conditions: []batch.JobCondition{
+					{
+						Type:    batch.JobSuccessCriteriaMet,
+						Status:  v1.ConditionFalse,
+						Reason:  "ConditionAddedManually",
+						Message: "Testing",
+					},
+				},
+			},
+			expectedActive: 1,
+			expectedReady:  ptr.To[int32](1),
+			expectedConditions: []batch.JobCondition{
+				{
+					Type:    batch.JobSuccessCriteriaMet,
+					Status:  v1.ConditionFalse,
+					Reason:  "ConditionAddedManually",
+					Message: "Testing",
+				},
+			},
+		},
 	}
 
 	for name, tc := range testCases {
@@ -1195,6 +1228,7 @@ func TestControllerSyncJob(t *testing.T) {
 			featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.PodIndexLabel, !tc.podIndexLabelDisabled)
 			featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobPodReplacementPolicy, tc.jobPodReplacementPolicy)
 			featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobPodFailurePolicy, tc.jobPodFailurePolicy)
+			featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobSuccessPolicy, tc.jobSuccessPolicy)
 			// job manager setup
 			clientSet := clientset.NewForConfigOrDie(&restclient.Config{Host: "", ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Group: "", Version: "v1"}}})