mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-22 19:31:44 +00:00
fix: golint errors in staging/src/k8s.io/apimachinery/pkg/api/validation
Signed-off-by: QianChenglong <qian_cheng_long@163.com>
This commit is contained in:
parent
9d3406c27b
commit
9372e80ec6
@ -262,8 +262,6 @@ staging/src/k8s.io/apimachinery/pkg/api/apitesting/fuzzer
|
|||||||
staging/src/k8s.io/apimachinery/pkg/api/apitesting/roundtrip
|
staging/src/k8s.io/apimachinery/pkg/api/apitesting/roundtrip
|
||||||
staging/src/k8s.io/apimachinery/pkg/api/meta
|
staging/src/k8s.io/apimachinery/pkg/api/meta
|
||||||
staging/src/k8s.io/apimachinery/pkg/api/resource
|
staging/src/k8s.io/apimachinery/pkg/api/resource
|
||||||
staging/src/k8s.io/apimachinery/pkg/api/validation
|
|
||||||
staging/src/k8s.io/apimachinery/pkg/api/validation/path
|
|
||||||
staging/src/k8s.io/apimachinery/pkg/apis/meta/fuzzer
|
staging/src/k8s.io/apimachinery/pkg/apis/meta/fuzzer
|
||||||
staging/src/k8s.io/apimachinery/pkg/apis/meta/internalversion
|
staging/src/k8s.io/apimachinery/pkg/apis/meta/internalversion
|
||||||
staging/src/k8s.io/apimachinery/pkg/apis/meta/v1
|
staging/src/k8s.io/apimachinery/pkg/apis/meta/v1
|
||||||
|
@ -23,6 +23,7 @@ import (
|
|||||||
"k8s.io/apimachinery/pkg/util/validation/field"
|
"k8s.io/apimachinery/pkg/util/validation/field"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// IsNegativeErrorMsg is a error message for value must be greater than or equal to 0.
|
||||||
const IsNegativeErrorMsg string = `must be greater than or equal to 0`
|
const IsNegativeErrorMsg string = `must be greater than or equal to 0`
|
||||||
|
|
||||||
// ValidateNameFunc validates that the provided name is valid for a given resource type.
|
// ValidateNameFunc validates that the provided name is valid for a given resource type.
|
||||||
@ -75,7 +76,7 @@ func maskTrailingDash(name string) string {
|
|||||||
return name
|
return name
|
||||||
}
|
}
|
||||||
|
|
||||||
// Validates that given value is not negative.
|
// ValidateNonnegativeField validates that given value is not negative.
|
||||||
func ValidateNonnegativeField(value int64, fldPath *field.Path) field.ErrorList {
|
func ValidateNonnegativeField(value int64, fldPath *field.Path) field.ErrorList {
|
||||||
allErrs := field.ErrorList{}
|
allErrs := field.ErrorList{}
|
||||||
if value < 0 {
|
if value < 0 {
|
||||||
|
@ -30,6 +30,7 @@ import (
|
|||||||
"k8s.io/apimachinery/pkg/util/validation/field"
|
"k8s.io/apimachinery/pkg/util/validation/field"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// FieldImmutableErrorMsg is a error message for field is immutable.
|
||||||
const FieldImmutableErrorMsg string = `field is immutable`
|
const FieldImmutableErrorMsg string = `field is immutable`
|
||||||
|
|
||||||
const totalAnnotationSizeLimitB int = 256 * (1 << 10) // 256 kB
|
const totalAnnotationSizeLimitB int = 256 * (1 << 10) // 256 kB
|
||||||
@ -80,6 +81,7 @@ func validateOwnerReference(ownerReference metav1.OwnerReference, fldPath *field
|
|||||||
return allErrs
|
return allErrs
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ValidateOwnerReferences validates that a set of owner references are correctly defined.
|
||||||
func ValidateOwnerReferences(ownerReferences []metav1.OwnerReference, fldPath *field.Path) field.ErrorList {
|
func ValidateOwnerReferences(ownerReferences []metav1.OwnerReference, fldPath *field.Path) field.ErrorList {
|
||||||
allErrs := field.ErrorList{}
|
allErrs := field.ErrorList{}
|
||||||
controllerName := ""
|
controllerName := ""
|
||||||
@ -97,7 +99,7 @@ func ValidateOwnerReferences(ownerReferences []metav1.OwnerReference, fldPath *f
|
|||||||
return allErrs
|
return allErrs
|
||||||
}
|
}
|
||||||
|
|
||||||
// Validate finalizer names
|
// ValidateFinalizerName validates finalizer names.
|
||||||
func ValidateFinalizerName(stringValue string, fldPath *field.Path) field.ErrorList {
|
func ValidateFinalizerName(stringValue string, fldPath *field.Path) field.ErrorList {
|
||||||
allErrs := field.ErrorList{}
|
allErrs := field.ErrorList{}
|
||||||
for _, msg := range validation.IsQualifiedName(stringValue) {
|
for _, msg := range validation.IsQualifiedName(stringValue) {
|
||||||
@ -107,6 +109,7 @@ func ValidateFinalizerName(stringValue string, fldPath *field.Path) field.ErrorL
|
|||||||
return allErrs
|
return allErrs
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ValidateNoNewFinalizers validates the new finalizers has no new finalizers compare to old finalizers.
|
||||||
func ValidateNoNewFinalizers(newFinalizers []string, oldFinalizers []string, fldPath *field.Path) field.ErrorList {
|
func ValidateNoNewFinalizers(newFinalizers []string, oldFinalizers []string, fldPath *field.Path) field.ErrorList {
|
||||||
allErrs := field.ErrorList{}
|
allErrs := field.ErrorList{}
|
||||||
extra := sets.NewString(newFinalizers...).Difference(sets.NewString(oldFinalizers...))
|
extra := sets.NewString(newFinalizers...).Difference(sets.NewString(oldFinalizers...))
|
||||||
@ -116,6 +119,7 @@ func ValidateNoNewFinalizers(newFinalizers []string, oldFinalizers []string, fld
|
|||||||
return allErrs
|
return allErrs
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ValidateImmutableField validates the new value and the old value are deeply equal.
|
||||||
func ValidateImmutableField(newVal, oldVal interface{}, fldPath *field.Path) field.ErrorList {
|
func ValidateImmutableField(newVal, oldVal interface{}, fldPath *field.Path) field.ErrorList {
|
||||||
allErrs := field.ErrorList{}
|
allErrs := field.ErrorList{}
|
||||||
if !apiequality.Semantic.DeepEqual(oldVal, newVal) {
|
if !apiequality.Semantic.DeepEqual(oldVal, newVal) {
|
||||||
@ -137,7 +141,7 @@ func ValidateObjectMeta(objMeta *metav1.ObjectMeta, requiresNamespace bool, name
|
|||||||
return ValidateObjectMetaAccessor(metadata, requiresNamespace, nameFn, fldPath)
|
return ValidateObjectMetaAccessor(metadata, requiresNamespace, nameFn, fldPath)
|
||||||
}
|
}
|
||||||
|
|
||||||
// ValidateObjectMeta validates an object's metadata on creation. It expects that name generation has already
|
// ValidateObjectMetaAccessor validates an object's metadata on creation. It expects that name generation has already
|
||||||
// been performed.
|
// been performed.
|
||||||
// It doesn't return an error for rootscoped resources with namespace, because namespace should already be cleared before.
|
// It doesn't return an error for rootscoped resources with namespace, because namespace should already be cleared before.
|
||||||
func ValidateObjectMetaAccessor(meta metav1.Object, requiresNamespace bool, nameFn ValidateNameFunc, fldPath *field.Path) field.ErrorList {
|
func ValidateObjectMetaAccessor(meta metav1.Object, requiresNamespace bool, nameFn ValidateNameFunc, fldPath *field.Path) field.ErrorList {
|
||||||
@ -208,7 +212,7 @@ func ValidateFinalizers(finalizers []string, fldPath *field.Path) field.ErrorLis
|
|||||||
return allErrs
|
return allErrs
|
||||||
}
|
}
|
||||||
|
|
||||||
// ValidateObjectMetaUpdate validates an object's metadata when updated
|
// ValidateObjectMetaUpdate validates an object's metadata when updated.
|
||||||
func ValidateObjectMetaUpdate(newMeta, oldMeta *metav1.ObjectMeta, fldPath *field.Path) field.ErrorList {
|
func ValidateObjectMetaUpdate(newMeta, oldMeta *metav1.ObjectMeta, fldPath *field.Path) field.ErrorList {
|
||||||
newMetadata, err := meta.Accessor(newMeta)
|
newMetadata, err := meta.Accessor(newMeta)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@ -225,6 +229,7 @@ func ValidateObjectMetaUpdate(newMeta, oldMeta *metav1.ObjectMeta, fldPath *fiel
|
|||||||
return ValidateObjectMetaAccessorUpdate(newMetadata, oldMetadata, fldPath)
|
return ValidateObjectMetaAccessorUpdate(newMetadata, oldMetadata, fldPath)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ValidateObjectMetaAccessorUpdate validates an object's metadata when updated.
|
||||||
func ValidateObjectMetaAccessorUpdate(newMeta, oldMeta metav1.Object, fldPath *field.Path) field.ErrorList {
|
func ValidateObjectMetaAccessorUpdate(newMeta, oldMeta metav1.Object, fldPath *field.Path) field.ErrorList {
|
||||||
var allErrs field.ErrorList
|
var allErrs field.ErrorList
|
||||||
|
|
||||||
|
@ -62,7 +62,7 @@ func IsValidPathSegmentPrefix(name string) []string {
|
|||||||
func ValidatePathSegmentName(name string, prefix bool) []string {
|
func ValidatePathSegmentName(name string, prefix bool) []string {
|
||||||
if prefix {
|
if prefix {
|
||||||
return IsValidPathSegmentPrefix(name)
|
return IsValidPathSegmentPrefix(name)
|
||||||
} else {
|
|
||||||
return IsValidPathSegmentName(name)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
return IsValidPathSegmentName(name)
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user