From a8ba361fd6532de0b8c29da56b405b81c1bb26c4 Mon Sep 17 00:00:00 2001 From: Michelle Au Date: Thu, 5 Dec 2019 13:32:17 -0800 Subject: [PATCH 1/2] expect node to be recreated with the same name --- test/e2e/storage/pd.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/storage/pd.go b/test/e2e/storage/pd.go index 88040aaa779..5b9645c30b9 100644 --- a/test/e2e/storage/pd.go +++ b/test/e2e/storage/pd.go @@ -405,7 +405,7 @@ var _ = utils.SIGDescribe("Pod Disks", func() { framework.ExpectEqual(numNodes, origNodeCnt, fmt.Sprintf("Requires current node count (%d) to return to original node count (%d)", numNodes, origNodeCnt)) output, err = gceCloud.ListInstanceNames(framework.TestContext.CloudConfig.ProjectID, framework.TestContext.CloudConfig.Zone) framework.ExpectNoError(err, fmt.Sprintf("Unable to get list of node instances err=%v output=%s", err, output)) - framework.ExpectEqual(false, strings.Contains(string(output), string(host0Name))) + framework.ExpectEqual(true, strings.Contains(string(output), string(host0Name))) } else if disruptOp == deleteNodeObj { ginkgo.By("deleting host0's node api object") From 2e6d6d73e7b1917cfbba6216af1b4b63619d58ad Mon Sep 17 00:00:00 2001 From: Michelle Au Date: Thu, 5 Dec 2019 14:26:17 -0800 Subject: [PATCH 2/2] disable node deletion detach test --- test/e2e/storage/pd.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/e2e/storage/pd.go b/test/e2e/storage/pd.go index 5b9645c30b9..8f9ae409fab 100644 --- a/test/e2e/storage/pd.go +++ b/test/e2e/storage/pd.go @@ -321,10 +321,12 @@ var _ = utils.SIGDescribe("Pod Disks", func() { disruptOp int // disruptive operation performed on target node } tests := []testT{ - { - descr: "node is deleted", - disruptOp: deleteNode, - }, + // https://github.com/kubernetes/kubernetes/issues/85972 + // This test case is flawed. Disabling for now. + // { + // descr: "node is deleted", + // disruptOp: deleteNode, + // }, { descr: "node's API object is deleted", disruptOp: deleteNodeObj,