From ac7239cddf3447a0184d38f8d6375ab7e187886d Mon Sep 17 00:00:00 2001 From: Michal Wozniak Date: Wed, 29 Jan 2025 20:23:50 +0100 Subject: [PATCH 1/2] WIP: fix the flaky Job integration tests --- test/integration/job/job_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/integration/job/job_test.go b/test/integration/job/job_test.go index 07c3f286994..cb39015bc3e 100644 --- a/test/integration/job/job_test.go +++ b/test/integration/job/job_test.go @@ -654,7 +654,7 @@ func TestSuccessPolicy(t *testing.T) { wantFailed: 0, wantSucceeded: 1, wantCompletedIndexes: "1", - wantTerminating: ptr.To[int32](1), + wantTerminating: ptr.To[int32](0), }, }, wantConditionTypes: []batchv1.JobConditionType{batchv1.JobSuccessCriteriaMet, batchv1.JobComplete}, @@ -1719,7 +1719,7 @@ func TestBackoffLimitPerIndex(t *testing.T) { }, wantFailed: 5, wantFailedIndexes: ptr.To(""), - wantTerminating: ptr.To[int32](2), + wantTerminating: ptr.To[int32](0), }, }, wantJobConditionType: batchv1.JobFailed, From 739d6155f4bb86b07145d0326417571552d16b24 Mon Sep 17 00:00:00 2001 From: Michal Wozniak Date: Thu, 30 Jan 2025 18:20:34 +0100 Subject: [PATCH 2/2] Fix the remaining flaky integration tests in Job controller --- test/integration/job/job_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/integration/job/job_test.go b/test/integration/job/job_test.go index cb39015bc3e..efe03e0fdd6 100644 --- a/test/integration/job/job_test.go +++ b/test/integration/job/job_test.go @@ -701,7 +701,7 @@ func TestSuccessPolicy(t *testing.T) { wantFailed: 0, wantSucceeded: 1, wantCompletedIndexes: "1", - wantTerminating: ptr.To[int32](1), + wantTerminating: ptr.To[int32](0), }, }, wantConditionTypes: []batchv1.JobConditionType{batchv1.JobSuccessCriteriaMet, batchv1.JobComplete}, @@ -1811,7 +1811,7 @@ func TestBackoffLimitPerIndex(t *testing.T) { wantActive: 0, wantFailed: 3, wantFailedIndexes: ptr.To("0,1"), - wantTerminating: ptr.To[int32](1), + wantTerminating: ptr.To[int32](0), }, }, wantJobConditionType: batchv1.JobFailed,