From f2fa6d5f6b37aedf3fd0b86270c7fb84c5618f70 Mon Sep 17 00:00:00 2001 From: Stephen Finucane Date: Thu, 6 Jul 2023 11:34:50 +0100 Subject: [PATCH] Document PVLabeler as deprecated This has no callers outside of the deprecated PersistentVolumeLabel admission controller, and it does not appear to be intended for implementation by external cloud provider implementations. The CSI topology feature, while not an exact equivalent, fulfils a very similar role. Indicate this. Signed-off-by: Stephen Finucane --- staging/src/k8s.io/cloud-provider/cloud.go | 1 + 1 file changed, 1 insertion(+) diff --git a/staging/src/k8s.io/cloud-provider/cloud.go b/staging/src/k8s.io/cloud-provider/cloud.go index c9a04085f48..6cbb10b59e4 100644 --- a/staging/src/k8s.io/cloud-provider/cloud.go +++ b/staging/src/k8s.io/cloud-provider/cloud.go @@ -285,6 +285,7 @@ type Zones interface { } // PVLabeler is an abstract, pluggable interface for fetching labels for volumes +// DEPRECATED: PVLabeler is deprecated in favor of CSI topology feature. type PVLabeler interface { GetLabelsForVolume(ctx context.Context, pv *v1.PersistentVolume) (map[string]string, error) }