diff --git a/pkg/health/exec.go b/pkg/health/exec.go index ba95f2f3ce2..74e9a6cf546 100644 --- a/pkg/health/exec.go +++ b/pkg/health/exec.go @@ -43,11 +43,11 @@ func IsExitError(err error) bool { return ok } -func (e *ExecHealthChecker) HealthCheck(podFullName string, currentState api.PodState, container api.Container) (Status, error) { +func (e *ExecHealthChecker) HealthCheck(podFullName, podUUID string, currentState api.PodState, container api.Container) (Status, error) { if container.LivenessProbe.Exec == nil { return Unknown, fmt.Errorf("Missing exec parameters") } - data, err := e.runner.RunInContainer(podFullName, currentState.Manifest.UUID, container.Name, container.LivenessProbe.Exec.Command) + data, err := e.runner.RunInContainer(podFullName, podUUID, container.Name, container.LivenessProbe.Exec.Command) glog.V(1).Infof("container %s failed health check: %s", podFullName, string(data)) if err != nil { if IsExitError(err) { diff --git a/pkg/health/exec_test.go b/pkg/health/exec_test.go index 28e1a9ccaf3..671ad1a7421 100644 --- a/pkg/health/exec_test.go +++ b/pkg/health/exec_test.go @@ -70,7 +70,7 @@ func TestExec(t *testing.T) { for _, test := range tests { fake.out = test.output fake.err = test.err - status, err := checker.HealthCheck("test", api.PodState{}, api.Container{LivenessProbe: test.probe}) + status, err := checker.HealthCheck("test", "", api.PodState{}, api.Container{LivenessProbe: test.probe}) if status != test.expectedStatus { t.Errorf("expected %v, got %v", test.expectedStatus, status) } diff --git a/pkg/health/health.go b/pkg/health/health.go index c978b00b7ba..1b4fdf6fffe 100644 --- a/pkg/health/health.go +++ b/pkg/health/health.go @@ -35,7 +35,7 @@ const ( // HealthChecker defines an abstract interface for checking container health. type HealthChecker interface { - HealthCheck(podFullName string, currentState api.PodState, container api.Container) (Status, error) + HealthCheck(podFullName, podUUID string, currentState api.PodState, container api.Container) (Status, error) CanCheck(probe *api.LivenessProbe) bool } @@ -78,13 +78,13 @@ func (m *muxHealthChecker) findCheckerFor(probe *api.LivenessProbe) HealthChecke // HealthCheck delegates the health-checking of the container to one of the bundled implementations. // If there is no health checker that can check container it returns Unknown, nil. -func (m *muxHealthChecker) HealthCheck(podFullName string, currentState api.PodState, container api.Container) (Status, error) { +func (m *muxHealthChecker) HealthCheck(podFullName, podUUID string, currentState api.PodState, container api.Container) (Status, error) { checker := m.findCheckerFor(container.LivenessProbe) if checker == nil { glog.Warningf("Failed to find health checker for %s %+v", container.Name, container.LivenessProbe) return Unknown, nil } - return checker.HealthCheck(podFullName, currentState, container) + return checker.HealthCheck(podFullName, podUUID, currentState, container) } func (m *muxHealthChecker) CanCheck(probe *api.LivenessProbe) bool { diff --git a/pkg/health/health_test.go b/pkg/health/health_test.go index 6c08a90bde8..65ce7ce49c5 100644 --- a/pkg/health/health_test.go +++ b/pkg/health/health_test.go @@ -67,7 +67,7 @@ func TestHealthChecker(t *testing.T) { }, } hc := NewHealthChecker() - health, err := hc.HealthCheck("test", api.PodState{}, container) + health, err := hc.HealthCheck("test", "", api.PodState{}, container) if err != nil && tt.health != Unknown { t.Errorf("Unexpected error: %v", err) } @@ -129,7 +129,7 @@ func TestMuxHealthChecker(t *testing.T) { } container.LivenessProbe.HTTPGet.Port = util.NewIntOrStringFromString(port) container.LivenessProbe.HTTPGet.Host = host - health, err := mc.HealthCheck("test", api.PodState{}, container) + health, err := mc.HealthCheck("test", "", api.PodState{}, container) if err != nil { t.Errorf("Unexpected error: %v", err) } diff --git a/pkg/health/http.go b/pkg/health/http.go index 18ced9faaf1..69b8330fb83 100644 --- a/pkg/health/http.go +++ b/pkg/health/http.go @@ -98,7 +98,7 @@ func DoHTTPCheck(url string, client HTTPGetInterface) (Status, error) { } // HealthCheck checks if the container is healthy by trying sending HTTP Get requests to the container. -func (h *HTTPHealthChecker) HealthCheck(podFullName string, currentState api.PodState, container api.Container) (Status, error) { +func (h *HTTPHealthChecker) HealthCheck(podFullName, podUUID string, currentState api.PodState, container api.Container) (Status, error) { host, port, path, err := getURLParts(currentState, container) if err != nil { return Unknown, err diff --git a/pkg/health/http_test.go b/pkg/health/http_test.go index 5fb57217ce8..78678cc5cf0 100644 --- a/pkg/health/http_test.go +++ b/pkg/health/http_test.go @@ -123,7 +123,7 @@ func TestHTTPHealthChecker(t *testing.T) { params.Port = util.NewIntOrStringFromString(port) params.Host = host } - health, err := hc.HealthCheck("test", api.PodState{PodIP: host}, container) + health, err := hc.HealthCheck("test", "", api.PodState{PodIP: host}, container) if test.health == Unknown && err == nil { t.Errorf("Expected error") } diff --git a/pkg/health/tcp.go b/pkg/health/tcp.go index 7253c7597d0..1968381fc33 100644 --- a/pkg/health/tcp.go +++ b/pkg/health/tcp.go @@ -74,7 +74,7 @@ func DoTCPCheck(addr string) (Status, error) { return Healthy, nil } -func (t *TCPHealthChecker) HealthCheck(podFullName string, currentState api.PodState, container api.Container) (Status, error) { +func (t *TCPHealthChecker) HealthCheck(podFullName, podUUID string, currentState api.PodState, container api.Container) (Status, error) { host, port, err := getTCPAddrParts(currentState, container) if err != nil { return Unknown, err diff --git a/pkg/health/tcp_test.go b/pkg/health/tcp_test.go index 2689ae615d1..5ba8ffbec92 100644 --- a/pkg/health/tcp_test.go +++ b/pkg/health/tcp_test.go @@ -100,7 +100,7 @@ func TestTcpHealthChecker(t *testing.T) { if params != nil && test.expectedStatus == Healthy { params.Port = util.NewIntOrStringFromString(port) } - status, err := checker.HealthCheck("test", api.PodState{PodIP: host}, container) + status, err := checker.HealthCheck("test", "", api.PodState{PodIP: host}, container) if status != test.expectedStatus { t.Errorf("expected: %v, got: %v", test.expectedStatus, status) } diff --git a/pkg/kubelet/kubelet.go b/pkg/kubelet/kubelet.go index 76feb49f22f..771c214c2e5 100644 --- a/pkg/kubelet/kubelet.go +++ b/pkg/kubelet/kubelet.go @@ -490,7 +490,7 @@ func (kl *Kubelet) syncPod(pod *Pod, dockerContainers dockertools.DockerContaine return err } - podState := api.PodState{Manifest: api.ContainerManifest{UUID: uuid}} + podState := api.PodState{} info, err := kl.GetPodInfo(podFullName, uuid) if err != nil { glog.Errorf("Unable to get pod with name %s and uuid %s info, health checks may be invalid.", @@ -510,7 +510,7 @@ func (kl *Kubelet) syncPod(pod *Pod, dockerContainers dockertools.DockerContaine // look for changes in the container. if hash == 0 || hash == expectedHash { // TODO: This should probably be separated out into a separate goroutine. - healthy, err := kl.healthy(podFullName, podState, container, dockerContainer) + healthy, err := kl.healthy(podFullName, uuid, podState, container, dockerContainer) if err != nil { glog.V(1).Infof("health check errored: %v", err) containersToKeep[containerID] = empty{} @@ -828,7 +828,7 @@ func (kl *Kubelet) GetMachineInfo() (*info.MachineInfo, error) { return cc.MachineInfo() } -func (kl *Kubelet) healthy(podFullName string, currentState api.PodState, container api.Container, dockerContainer *docker.APIContainers) (health.Status, error) { +func (kl *Kubelet) healthy(podFullName, podUUID string, currentState api.PodState, container api.Container, dockerContainer *docker.APIContainers) (health.Status, error) { // Give the container 60 seconds to start up. if container.LivenessProbe == nil { return health.Healthy, nil @@ -839,7 +839,7 @@ func (kl *Kubelet) healthy(podFullName string, currentState api.PodState, contai if kl.healthChecker == nil { return health.Healthy, nil } - return kl.healthChecker.HealthCheck(podFullName, currentState, container) + return kl.healthChecker.HealthCheck(podFullName, podUUID, currentState, container) } // Returns logs of current machine. diff --git a/pkg/kubelet/kubelet_test.go b/pkg/kubelet/kubelet_test.go index dfeb7fabdf1..df323fccc26 100644 --- a/pkg/kubelet/kubelet_test.go +++ b/pkg/kubelet/kubelet_test.go @@ -506,7 +506,7 @@ func TestSyncPodDeletesDuplicate(t *testing.T) { type FalseHealthChecker struct{} -func (f *FalseHealthChecker) HealthCheck(podFullName string, state api.PodState, container api.Container) (health.Status, error) { +func (f *FalseHealthChecker) HealthCheck(podFullName, podUUID string, state api.PodState, container api.Container) (health.Status, error) { return health.Unhealthy, nil }