diff --git a/pkg/BUILD b/pkg/BUILD index da105e0cf47..c9206cd8432 100644 --- a/pkg/BUILD +++ b/pkg/BUILD @@ -57,7 +57,7 @@ filegroup( "//pkg/client/listers/scheduling/internalversion:all-srcs", "//pkg/client/listers/settings/internalversion:all-srcs", "//pkg/client/listers/storage/internalversion:all-srcs", - "//pkg/client/metrics:all-srcs", + "//pkg/client/metrics/prometheus:all-srcs", "//pkg/client/testdata:all-srcs", "//pkg/client/tests:all-srcs", "//pkg/client/unversioned:all-srcs", diff --git a/pkg/client/metrics/BUILD b/pkg/client/metrics/BUILD deleted file mode 100644 index 490177eaed5..00000000000 --- a/pkg/client/metrics/BUILD +++ /dev/null @@ -1,27 +0,0 @@ -package(default_visibility = ["//visibility:public"]) - -load( - "@io_bazel_rules_go//go:def.bzl", - "go_library", -) - -go_library( - name = "go_default_library", - srcs = ["metrics.go"], -) - -filegroup( - name = "package-srcs", - srcs = glob(["**"]), - tags = ["automanaged"], - visibility = ["//visibility:private"], -) - -filegroup( - name = "all-srcs", - srcs = [ - ":package-srcs", - "//pkg/client/metrics/prometheus:all-srcs", - ], - tags = ["automanaged"], -) diff --git a/pkg/client/metrics/metrics.go b/pkg/client/metrics/metrics.go deleted file mode 100644 index a01306c65df..00000000000 --- a/pkg/client/metrics/metrics.go +++ /dev/null @@ -1,61 +0,0 @@ -/* -Copyright 2015 The Kubernetes Authors. - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. -*/ - -// Package metrics provides abstractions for registering which metrics -// to record. -package metrics - -import ( - "net/url" - "sync" - "time" -) - -var registerMetrics sync.Once - -// LatencyMetric observes client latency partitioned by verb and url. -type LatencyMetric interface { - Observe(verb string, u url.URL, latency time.Duration) -} - -// ResultMetric counts response codes partitioned by method and host. -type ResultMetric interface { - Increment(code string, method string, host string) -} - -var ( - // RequestLatency is the latency metric that rest clients will update. - RequestLatency LatencyMetric = noopLatency{} - // RequestResult is the result metric that rest clients will update. - RequestResult ResultMetric = noopResult{} -) - -// Register registers metrics for the rest client to use. This can -// only be called once. -func Register(lm LatencyMetric, rm ResultMetric) { - registerMetrics.Do(func() { - RequestLatency = lm - RequestResult = rm - }) -} - -type noopLatency struct{} - -func (noopLatency) Observe(string, url.URL, time.Duration) {} - -type noopResult struct{} - -func (noopResult) Increment(string, string, string) {} diff --git a/pkg/client/metrics/prometheus/BUILD b/pkg/client/metrics/prometheus/BUILD index 519bca71ca3..b2c562b7b38 100644 --- a/pkg/client/metrics/prometheus/BUILD +++ b/pkg/client/metrics/prometheus/BUILD @@ -9,8 +9,8 @@ go_library( name = "go_default_library", srcs = ["prometheus.go"], deps = [ - "//pkg/client/metrics:go_default_library", "//vendor/github.com/prometheus/client_golang/prometheus:go_default_library", + "//vendor/k8s.io/client-go/tools/metrics:go_default_library", ], ) diff --git a/pkg/client/metrics/prometheus/prometheus.go b/pkg/client/metrics/prometheus/prometheus.go index d9265f4ddc3..45a08f6500e 100644 --- a/pkg/client/metrics/prometheus/prometheus.go +++ b/pkg/client/metrics/prometheus/prometheus.go @@ -22,7 +22,7 @@ import ( "net/url" "time" - "k8s.io/kubernetes/pkg/client/metrics" + "k8s.io/client-go/tools/metrics" "github.com/prometheus/client_golang/prometheus" )