From 1d2c96ad5e90e41259595fd49bdd082ce812c393 Mon Sep 17 00:00:00 2001 From: mattjmcnaughton Date: Fri, 12 Jul 2019 11:48:53 -0400 Subject: [PATCH] Improve readability for image manager tests Use named variables so boolean arguments are more readable. --- pkg/kubelet/images/image_manager_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/kubelet/images/image_manager_test.go b/pkg/kubelet/images/image_manager_test.go index b9d2ae78338..d2e27dcd73a 100644 --- a/pkg/kubelet/images/image_manager_test.go +++ b/pkg/kubelet/images/image_manager_test.go @@ -145,8 +145,9 @@ func TestParallelPuller(t *testing.T) { cases := pullerTestCases() + useSerializedEnv := false for i, c := range cases { - puller, fakeClock, fakeRuntime, container := pullerTestEnv(c, false) + puller, fakeClock, fakeRuntime, container := pullerTestEnv(c, useSerializedEnv) for tick, expected := range c.expected { fakeRuntime.CalledFunctions = nil @@ -170,8 +171,9 @@ func TestSerializedPuller(t *testing.T) { cases := pullerTestCases() + useSerializedEnv := true for i, c := range cases { - puller, fakeClock, fakeRuntime, container := pullerTestEnv(c, true) + puller, fakeClock, fakeRuntime, container := pullerTestEnv(c, useSerializedEnv) for tick, expected := range c.expected { fakeRuntime.CalledFunctions = nil