diff --git a/pkg/controller/service/BUILD b/pkg/controller/service/BUILD index f7004cb9cfe..1a7148ac713 100644 --- a/pkg/controller/service/BUILD +++ b/pkg/controller/service/BUILD @@ -28,7 +28,6 @@ go_library( "//pkg/util/metrics:go_default_library", "//vendor/github.com/golang/glog:go_default_library", "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library", - "//vendor/k8s.io/apimachinery/pkg/labels:go_default_library", "//vendor/k8s.io/apimachinery/pkg/util/runtime:go_default_library", "//vendor/k8s.io/apimachinery/pkg/util/wait:go_default_library", "//vendor/k8s.io/client-go/kubernetes/typed/core/v1:go_default_library", diff --git a/pkg/controller/service/servicecontroller.go b/pkg/controller/service/servicecontroller.go index 11b99ac3966..3ea05d4431e 100644 --- a/pkg/controller/service/servicecontroller.go +++ b/pkg/controller/service/servicecontroller.go @@ -26,7 +26,6 @@ import ( "github.com/golang/glog" "k8s.io/apimachinery/pkg/api/errors" - "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/util/runtime" "k8s.io/apimachinery/pkg/util/wait" v1core "k8s.io/client-go/kubernetes/typed/core/v1" @@ -348,22 +347,15 @@ func (s *ServiceController) persistUpdate(service *v1.Service) error { } func (s *ServiceController) createLoadBalancer(service *v1.Service) (*v1.LoadBalancerStatus, error) { - nodes, err := s.nodeLister.List(labels.Everything()) + nodes, err := s.nodeLister.ListWithPredicate(getNodeConditionPredicate()) if err != nil { return nil, err } - lbNodes := []*v1.Node{} - for ix := range nodes { - if includeNodeFromNodeList(nodes[ix]) { - lbNodes = append(lbNodes, nodes[ix]) - } - } - // - Only one protocol supported per service // - Not all cloud providers support all protocols and the next step is expected to return // an error for unsupported protocols - return s.balancer.EnsureLoadBalancer(s.clusterName, service, lbNodes) + return s.balancer.EnsureLoadBalancer(s.clusterName, service, nodes) } // ListKeys implements the interface required by DeltaFIFO to list the keys we