github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 23:37:01 +00:00
Code Issues Projects Releases Wiki Activity

Fix AWS volume detach

Browse Source
This commit is contained in:
Justin Santa Barbara 2015-05-25 15:05:56 -04:00
parent b7b89c4734
commit 97a312f72c
2 changed files with 40 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
pkg/cloudprovider/aws/aws.go
View File

@ -48,9 +48,8 @@ type EC2 interface {
// Attach a volume to an instance // Attach a volume to an instance
AttachVolume(volumeID, instanceId, mountDevice string) (resp *ec2.VolumeAttachment, err error) AttachVolume(volumeID, instanceId, mountDevice string) (resp *ec2.VolumeAttachment, err error)
// Detach a volume from whatever instance it is attached to // Detach a volume from an instance it is attached to
// TODO: We should specify the InstanceID and the Device, for safety DetachVolume(request *ec2.DetachVolumeInput) (resp *ec2.VolumeAttachment, err error)
DetachVolume(volumeID, instanceId, mountDevice string) (resp *ec2.VolumeAttachment, err error)
// Lists volumes // Lists volumes
Volumes(volumeIDs []string, filter *ec2.Filter) (resp *ec2.DescribeVolumesOutput, err error) Volumes(volumeIDs []string, filter *ec2.Filter) (resp *ec2.DescribeVolumesOutput, err error)
// Create an EBS volume // Create an EBS volume
@ -224,13 +223,8 @@ func (s *awsSdkEC2) AttachVolume(volumeID, instanceId, device string) (resp *ec2
return s.ec2.AttachVolume(&request) return s.ec2.AttachVolume(&request)
} }
func (s *awsSdkEC2) DetachVolume(volumeID, instanceId, device string) (resp *ec2.VolumeAttachment, err error) { func (s *awsSdkEC2) DetachVolume(request *ec2.DetachVolumeInput) (*ec2.VolumeAttachment, error) {
request := ec2.DetachVolumeInput{ return s.ec2.DetachVolume(request)
Device: &device,
InstanceID: &instanceId,
VolumeID: &volumeID,
}
return s.ec2.DetachVolume(&request)
} }
func (s *awsSdkEC2) Volumes(volumeIDs []string, filter *ec2.Filter) (resp *ec2.DescribeVolumesOutput, err error) { func (s *awsSdkEC2) Volumes(volumeIDs []string, filter *ec2.Filter) (resp *ec2.DescribeVolumesOutput, err error) {
@ -963,6 +957,27 @@ func (aws *AWSCloud) getSelfAWSInstance() (*awsInstance, error) {
return i, nil return i, nil
} }
// Gets the awsInstance named instanceName, or the 'self' instance if instanceName == ""
func (aws *AWSCloud) getAwsInstance(instanceName string) (*awsInstance, error) {
var awsInstance *awsInstance
var err error
if instanceName == "" {
awsInstance, err = aws.getSelfAWSInstance()
if err != nil {
return nil, fmt.Errorf("error getting self-instance: %v", err)
}
} else {
instance, err := aws.getInstancesByDnsName(instanceName)
if err != nil {
return nil, fmt.Errorf("error finding instance: %v", err)
}
awsInstance = newAWSInstance(aws.ec2, *instance.InstanceID)
}
return awsInstance, nil
}
// Implements Volumes.AttachDisk // Implements Volumes.AttachDisk
func (aws *AWSCloud) AttachDisk(instanceName string, diskName string, readOnly bool) (string, error) { func (aws *AWSCloud) AttachDisk(instanceName string, diskName string, readOnly bool) (string, error) {
disk, err := newAWSDisk(aws.ec2, diskName) disk, err := newAWSDisk(aws.ec2, diskName)
@ -970,19 +985,9 @@ func (aws *AWSCloud) AttachDisk(instanceName string, diskName string, readOnly b
return "", err return "", err
} }
var awsInstance *awsInstance awsInstance, err := aws.getAwsInstance(instanceName)
if instanceName == "" { if err != nil {
awsInstance, err = aws.getSelfAWSInstance() return "", err
if err != nil {
return "", fmt.Errorf("Error getting self-instance: %v", err)
}
} else {
instance, err := aws.getInstancesByDnsName(instanceName)
if err != nil {
return "", fmt.Errorf("Error finding instance: %v", err)
}
awsInstance = newAWSInstance(aws.ec2, *instance.InstanceID)
} }
if readOnly { if readOnly {
@ -1035,8 +1040,17 @@ func (aws *AWSCloud) DetachDisk(instanceName string, diskName string) error {
return err return err
} }
// TODO: We should specify the InstanceID and the Device, for safety awsInstance, err := aws.getAwsInstance(instanceName)
response, err := aws.ec2.DetachVolume(disk.awsID, instanceName, diskName) if err != nil {
return err
}
request := ec2.DetachVolumeInput{
InstanceID: &awsInstance.awsID,
VolumeID: &disk.awsID,
}
response, err := aws.ec2.DetachVolume(&request)
if err != nil { if err != nil {
return fmt.Errorf("error detaching EBS volume: %v", err) return fmt.Errorf("error detaching EBS volume: %v", err)
} }

2
pkg/cloudprovider/aws/aws_test.go
View File

@ -208,7 +208,7 @@ func (ec2 *FakeEC2) AttachVolume(volumeID, instanceId, mountDevice string) (resp
panic("Not implemented") panic("Not implemented")
} }
func (ec2 *FakeEC2) DetachVolume(volumeID, instanceId, mountDevice string) (resp *ec2.VolumeAttachment, err error) { func (ec2 *FakeEC2) DetachVolume(request *ec2.DetachVolumeInput) (resp *ec2.VolumeAttachment, err error) {
panic("Not implemented") panic("Not implemented")
} }