github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 12:43:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #63434 from adfinis-forks/bug_typo_kubelet_volume_stats

Browse Source 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix typo in volume_stats.go

**What this PR does / why we need it**:
While reviewing the implementation details I came across a typo in volume_stats.go
sed/volumeStatsCollecotr/volumeStatsCollector/

**Release note**:

```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2018-05-24 11:44:20 -07:00 committed by GitHub
commit 97f4a64fac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/kubelet/metrics/collectors/volume_stats.go
View File

@ -58,17 +58,17 @@ var (
) )
) )
type volumeStatsCollecotr struct { type volumeStatsCollector struct {
statsProvider serverstats.StatsProvider statsProvider serverstats.StatsProvider
} }
// NewVolumeStatsCollector creates a volume stats prometheus collector. // NewVolumeStatsCollector creates a volume stats prometheus collector.
func NewVolumeStatsCollector(statsProvider serverstats.StatsProvider) prometheus.Collector { func NewVolumeStatsCollector(statsProvider serverstats.StatsProvider) prometheus.Collector {
return &volumeStatsCollecotr{statsProvider: statsProvider} return &volumeStatsCollector{statsProvider: statsProvider}
} }
// Describe implements the prometheus.Collector interface. // Describe implements the prometheus.Collector interface.
func (collector *volumeStatsCollecotr) Describe(ch chan<- *prometheus.Desc) { func (collector *volumeStatsCollector) Describe(ch chan<- *prometheus.Desc) {
ch <- volumeStatsCapacityBytesDesc ch <- volumeStatsCapacityBytesDesc
ch <- volumeStatsAvailableBytesDesc ch <- volumeStatsAvailableBytesDesc
ch <- volumeStatsUsedBytesDesc ch <- volumeStatsUsedBytesDesc
@ -78,7 +78,7 @@ func (collector *volumeStatsCollecotr) Describe(ch chan<- *prometheus.Desc) {
} }
// Collect implements the prometheus.Collector interface. // Collect implements the prometheus.Collector interface.
func (collector *volumeStatsCollecotr) Collect(ch chan<- prometheus.Metric) { func (collector *volumeStatsCollector) Collect(ch chan<- prometheus.Metric) {
podStats, err := collector.statsProvider.ListPodStats() podStats, err := collector.statsProvider.ListPodStats()
if err != nil { if err != nil {
return return

2
pkg/kubelet/metrics/collectors/volume_stats_test.go
View File

@ -129,7 +129,7 @@ func TestVolumeStatsCollector(t *testing.T) {
mockStatsProvider := new(statstest.StatsProvider) mockStatsProvider := new(statstest.StatsProvider)
mockStatsProvider.On("ListPodStats").Return(podStats, nil) mockStatsProvider.On("ListPodStats").Return(podStats, nil)
if err := gatherAndCompare(&volumeStatsCollecotr{statsProvider: mockStatsProvider}, want, metrics); err != nil { if err := gatherAndCompare(&volumeStatsCollector{statsProvider: mockStatsProvider}, want, metrics); err != nil {
t.Errorf("unexpected collecting result:\n%s", err) t.Errorf("unexpected collecting result:\n%s", err)
} }
} }