github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 09:22:44 +00:00
Code Issues Projects Releases Wiki Activity

Make gce operation polling more robust.

Browse Source 
Only fail the operation if we cannot poll it 3 consecutive times.
This commit is contained in:
CJ Cullen 2015-07-30 14:26:08 -07:00
parent c752bc6ffb
commit 983748b2e2
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/cloudprovider/gce/gce.go
View File

@ -276,14 +276,20 @@ func (gce *GCECloud) targetPoolURL(name, region string) string {
func waitForOp(op *compute.Operation, getOperation func() (*compute.Operation, error)) error { func waitForOp(op *compute.Operation, getOperation func() (*compute.Operation, error)) error {
pollOp := op pollOp := op
consecPollFails := 0
for pollOp.Status != "DONE" { for pollOp.Status != "DONE" {
var err error var err error
// TODO: add some backoff here. time.Sleep(3 * time.Second)
time.Sleep(time.Second)
pollOp, err = getOperation() pollOp, err = getOperation()
if err != nil { if err != nil {
if consecPollFails == 2 {
// Only bail if we've seen 3 consecutive polling errors.
return err return err
} }
consecPollFails++
} else {
consecPollFails = 0
}
} }
if pollOp.Error != nil && len(pollOp.Error.Errors) > 0 { if pollOp.Error != nil && len(pollOp.Error.Errors) > 0 {
return &googleapi.Error{ return &googleapi.Error{