github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

Add kubectl describe CSINode test coverage

Browse Source
This commit is contained in:
zhouya0 2020-03-31 12:15:20 +08:00
parent 238d2c8776
commit 991547edb6
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
staging/src/k8s.io/kubectl/pkg/describe/describe.go
View File

@ -4032,7 +4032,7 @@ func describeCSINode(csi *storagev1.CSINode, events *corev1.EventList) (output s
for _, driver := range csi.Spec.Drivers {
w.Write(LEVEL_2, "%s:\n", driver.Name)
w.Write(LEVEL_3, "Node ID:\t%s\n", driver.NodeID)
if driver.Allocatable.Count != nil {
if driver.Allocatable != nil && driver.Allocatable.Count != nil {
w.Write(LEVEL_3, "Allocatables:\n")
w.Write(LEVEL_4, "Count:\t%d\n", *driver.Allocatable.Count)
}

32
staging/src/k8s.io/kubectl/pkg/describe/describe_test.go
View File

@ -1780,6 +1780,38 @@ func TestDescribeStorageClass(t *testing.T) {
}
}
func TestDescribeCSINode(t *testing.T) {
limit := utilpointer.Int32Ptr(int32(2))
f := fake.NewSimpleClientset(&storagev1.CSINode{
ObjectMeta: metav1.ObjectMeta{Name: "foo"},
Spec: storagev1.CSINodeSpec{
Drivers: []storagev1.CSINodeDriver{
{
Name: "driver1",
NodeID: "node1",
},
{
Name: "driver2",
NodeID: "node2",
Allocatable: &storagev1.VolumeNodeResources{Count: limit},
},
},
},
})
s := CSINodeDescriber{f}
out, err := s.Describe("", "foo", DescriberSettings{ShowEvents: true})
if err != nil {
t.Errorf("unexpected error: %v", err)
}
if !strings.Contains(out, "foo") ||
!strings.Contains(out, "driver1") ||
!strings.Contains(out, "node1") ||
!strings.Contains(out, "driver2") ||
!strings.Contains(out, "node2") {
t.Errorf("unexpected out: %s", out)
}
}
func TestDescribePodDisruptionBudget(t *testing.T) {
minAvailable := intstr.FromInt(22)
f := fake.NewSimpleClientset(&policyv1beta1.PodDisruptionBudget{