Fix problems identified in review

This commit is contained in:
Justin Santa Barbara
2015-03-13 18:07:08 -04:00
parent bc16d83a51
commit 99da56fb06
4 changed files with 6 additions and 6 deletions

View File

@@ -274,7 +274,7 @@ func (s *NodeController) PopulateAddresses(nodes *api.NodeList) (*api.NodeList,
if err != nil {
glog.Errorf("error getting instance addresses for %s: %v", node.Name, err)
} else {
api.AddToNodeAddresses(&node.Status.Addresses, nodeAddresses...)
node.Status.Addresses = nodeAddresses
}
}
} else {
@@ -283,7 +283,7 @@ func (s *NodeController) PopulateAddresses(nodes *api.NodeList) (*api.NodeList,
addr := net.ParseIP(node.Name)
if addr != nil {
address := api.NodeAddress{Type: api.NodeLegacyHostIP, Address: addr.String()}
api.AddToNodeAddresses(&node.Status.Addresses, address)
node.Status.Addresses = []api.NodeAddress{address}
} else {
addrs, err := s.lookupIP(node.Name)
if err != nil {
@@ -292,7 +292,7 @@ func (s *NodeController) PopulateAddresses(nodes *api.NodeList) (*api.NodeList,
glog.Errorf("No ip address for node %v", node.Name)
} else {
address := api.NodeAddress{Type: api.NodeLegacyHostIP, Address: addrs[0].String()}
api.AddToNodeAddresses(&node.Status.Addresses, address)
node.Status.Addresses = []api.NodeAddress{address}
}
}
}