From 9a0add3c96964706d095118056cf30f00559f4d2 Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Mon, 22 Sep 2014 15:56:28 -0400 Subject: [PATCH] runtime.RawExtension must copy the buffer, not use it --- pkg/runtime/extension.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/runtime/extension.go b/pkg/runtime/extension.go index 4d731cb4838..eebc9dcfa94 100644 --- a/pkg/runtime/extension.go +++ b/pkg/runtime/extension.go @@ -17,11 +17,16 @@ limitations under the License. package runtime import ( + "errors" + "gopkg.in/v1/yaml" ) func (re *RawExtension) UnmarshalJSON(in []byte) error { - re.RawJSON = in + if re == nil { + return errors.New("runtime.RawExtension: UnmarshalJSON on nil pointer") + } + re.RawJSON = append(re.RawJSON[0:0], in...) return nil }