github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #57143 from sttts/sttts-clientgen-no-base-dirs

Browse Source 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

client-gen: remove base input dirs

Were these dirs some kind of cargo cult? Removing them causes no change to the generated code.

Background: having those packages in the list of input dirs makes them mandatory to exist. If people use code-gen on a project that does not vendor them (due to vendor/ pruning), code-gen fails.

Fixes https://github.com/kubernetes/sample-controller/issues/8
This commit is contained in:
Kubernetes Submit Queue 2018-02-08 07:09:58 -08:00 committed by GitHub
commit 9a3d2795ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
staging/src/k8s.io/code-generator/cmd/client-gen/args/args.go
View File

@ -27,12 +27,7 @@ import (
codegenutil "k8s.io/code-generator/pkg/util"
)
var DefaultInputDirs = []string{
"k8s.io/apimachinery/pkg/fields",
"k8s.io/apimachinery/pkg/labels",
"k8s.io/apimachinery/pkg/watch",
"k8s.io/apimachinery/pkg/apimachinery/registered",
}
var DefaultInputDirs = []string{}
// ClientGenArgs is a wrapper for arguments to client-gen.
type CustomArgs struct {