github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-12-07 18:06:21 +00:00
Code Issues Projects Releases Wiki Activity

remove VM API call dep in azure disk WaitForAttach

Browse Source 
add comment

add unit test for WaitForAttach fnc

add unit test for WaitForAttach Func
This commit is contained in:
andyzhangx
2019-05-06 06:43:33 +00:00
parent df3e59fedc
commit 9a8f07dd9f
6 changed files with 119 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
pkg/volume/azure_dd/azure_common_test.go
View File

@@ -183,57 +183,42 @@ func TestNormalizeStorageAccountType(t *testing.T) {
}
}
func TestGetDiskLUN(t *testing.T) {
func TestGetDiskNum(t *testing.T) {
tests := []struct {
deviceInfo string
expectedLUN int32
expectedNum string
expectError bool
}{
{
deviceInfo: "0",
expectedLUN: 0,
deviceInfo: "/dev/disk0",
expectedNum: "0",
expectError: false,
},
{
deviceInfo: "10",
expectedLUN: 10,
deviceInfo: "/dev/disk99",
expectedNum: "99",
expectError: false,
},
{
deviceInfo: "11d",
expectedLUN: -1,
deviceInfo: "",
expectedNum: "",
expectError: true,
},
{
deviceInfo: "/dev/disk",
expectedNum: "",
expectError: true,
},
{
deviceInfo: "999",
expectedLUN: -1,
expectError: true,
},
{
deviceInfo: "",
expectedLUN: -1,
expectError: true,
},
{
deviceInfo: "/dev/disk/azure/scsi1/lun2",
expectedLUN: 2,
expectError: false,
},
{
deviceInfo: "/dev/disk/azure/scsi0/lun12",
expectedLUN: 12,
expectError: false,
},
{
deviceInfo: "/dev/disk/by-id/scsi1/lun2",
expectedLUN: -1,
expectedNum: "",
expectError: true,
},
}
for _, test := range tests {
result, err := getDiskLUN(test.deviceInfo)
assert.Equal(t, result, test.expectedLUN)
result, err := getDiskNum(test.deviceInfo)
assert.Equal(t, result, test.expectedNum)
assert.Equal(t, err != nil, test.expectError, fmt.Sprintf("error msg: %v", err))
}
}