From 5bc2560b1f4e5e7f213ecc121611e272ad1badd9 Mon Sep 17 00:00:00 2001 From: mqliang Date: Thu, 19 Nov 2015 12:22:36 +0800 Subject: [PATCH] refactor:move `GetNewRCTemplate()` out of for loop --- pkg/util/deployment/deployment.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/util/deployment/deployment.go b/pkg/util/deployment/deployment.go index 59806d8acd3..8d0bfb3b54b 100644 --- a/pkg/util/deployment/deployment.go +++ b/pkg/util/deployment/deployment.go @@ -43,13 +43,13 @@ func GetOldRCs(deployment extensions.Deployment, c client.Interface) ([]*api.Rep if err != nil { return nil, fmt.Errorf("error listing replication controllers: %v", err) } + newRCTemplate := GetNewRCTemplate(deployment) for _, pod := range podList.Items { podLabelsSelector := labels.Set(pod.ObjectMeta.Labels) for _, rc := range rcList.Items { rcLabelsSelector := labels.SelectorFromSet(rc.Spec.Selector) if rcLabelsSelector.Matches(podLabelsSelector) { // Filter out RC that has the same pod template spec as the deployment - that is the new RC. - newRCTemplate := GetNewRCTemplate(deployment) if api.Semantic.DeepEqual(rc.Spec.Template, &newRCTemplate) { continue }