github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

add unit test for pkg/kubelet/types/ func GetPodStartTime()

Browse Source 
Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
This commit is contained in:
zhoumingcheng 2022-07-14 16:10:15 +08:00
parent 15f111f78f
commit 9b6f880dbc
1 changed files with 51 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
pkg/scheduler/util/utils_test.go
View File

@ -23,7 +23,6 @@ import (
"time" "time"
"github.com/google/go-cmp/cmp" "github.com/google/go-cmp/cmp"
v1 "k8s.io/api/core/v1" v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime"
@ -61,27 +60,59 @@ func newPriorityPodWithStartTime(name string, priority int32, startTime time.Tim
} }
func TestGetEarliestPodStartTime(t *testing.T) { func TestGetEarliestPodStartTime(t *testing.T) {
var priority int32 = 1
currentTime := time.Now() currentTime := time.Now()
pod1 := newPriorityPodWithStartTime("pod1", 1, currentTime.Add(time.Second)) tests := []struct {
pod2 := newPriorityPodWithStartTime("pod2", 2, currentTime.Add(time.Second)) name string
pod3 := newPriorityPodWithStartTime("pod3", 2, currentTime) pods []*v1.Pod
victims := &extenderv1.Victims{ expectedStartTime *metav1.Time
Pods: []*v1.Pod{pod1, pod2, pod3}, }{
{
name: "Pods length is 0",
pods: []*v1.Pod{},
expectedStartTime: nil,
},
{
name: "generate new startTime",
pods: []*v1.Pod{
newPriorityPodWithStartTime("pod1", 1, currentTime.Add(-time.Second)),
{
ObjectMeta: metav1.ObjectMeta{
Name: "pod2",
},
Spec: v1.PodSpec{
Priority: &priority,
},
},
},
expectedStartTime: &metav1.Time{Time: currentTime.Add(-time.Second)},
},
{
name: "Pod with earliest start time last in the list",
pods: []*v1.Pod{
newPriorityPodWithStartTime("pod1", 1, currentTime.Add(time.Second)),
newPriorityPodWithStartTime("pod2", 2, currentTime.Add(time.Second)),
newPriorityPodWithStartTime("pod3", 2, currentTime),
},
expectedStartTime: &metav1.Time{Time: currentTime},
},
{
name: "Pod with earliest start time first in the list",
pods: []*v1.Pod{
newPriorityPodWithStartTime("pod1", 2, currentTime),
newPriorityPodWithStartTime("pod2", 2, currentTime.Add(time.Second)),
newPriorityPodWithStartTime("pod3", 2, currentTime.Add(2*time.Second)),
},
expectedStartTime: &metav1.Time{Time: currentTime},
},
} }
startTime := GetEarliestPodStartTime(victims) for _, test := range tests {
if !startTime.Equal(pod3.Status.StartTime) { t.Run(test.name, func(t *testing.T) {
t.Errorf("Got wrong earliest pod start time") startTime := GetEarliestPodStartTime(&extenderv1.Victims{Pods: test.pods})
} if !startTime.Equal(test.expectedStartTime) {
t.Errorf("startTime is not the expected result,got %v, expected %v", startTime, test.expectedStartTime)
pod1 = newPriorityPodWithStartTime("pod1", 2, currentTime) }
pod2 = newPriorityPodWithStartTime("pod2", 2, currentTime.Add(time.Second)) })
pod3 = newPriorityPodWithStartTime("pod3", 2, currentTime.Add(2*time.Second))
victims = &extenderv1.Victims{
Pods: []*v1.Pod{pod1, pod2, pod3},
}
startTime = GetEarliestPodStartTime(victims)
if !startTime.Equal(pod1.Status.StartTime) {
t.Errorf("Got wrong earliest pod start time, got %v, expected %v", startTime, pod1.Status.StartTime)
} }
} }