From 9c1b29ece179508477d6ec64d94011adb4b25fe5 Mon Sep 17 00:00:00 2001 From: Xing Yang Date: Tue, 28 Aug 2018 06:14:14 -0700 Subject: [PATCH] Modify comments for DataSource --- pkg/apis/core/types.go | 8 ++++---- staging/src/k8s.io/api/core/v1/types.go | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/apis/core/types.go b/pkg/apis/core/types.go index 99f033a3ca2..e7c634f7d78 100644 --- a/pkg/apis/core/types.go +++ b/pkg/apis/core/types.go @@ -415,10 +415,10 @@ type PersistentVolumeClaimSpec struct { VolumeMode *PersistentVolumeMode // If specified, volume will be prepopulated with data from the specified data source. // This depends on the provisioner for this volume being able to use the specified source. - // If the provisioner failed to populate the volume with the source, it will return an - // error and fail the create volume operation. If the provisioner does not support the - // data source, it will also return an error and fail the create volume operation. - // It requires the VolumeSnapshotDataSource alpha feature gate to be enabled and + // If the provisioner failed to create volume from the data source, the behavior will be + // the same as the no data source case. In this failure case, PV will not be created, PVC + // will be in the pending state, and the controller will keep retrying to create the volume. + // This requires the VolumeSnapshotDataSource alpha feature gate to be enabled and // currently VolumeSnapshot is the only supported data source. // In the future, we will allow more data source types when new feature is ready. // +optional diff --git a/staging/src/k8s.io/api/core/v1/types.go b/staging/src/k8s.io/api/core/v1/types.go index cad69a6d6a3..793a7a20eef 100644 --- a/staging/src/k8s.io/api/core/v1/types.go +++ b/staging/src/k8s.io/api/core/v1/types.go @@ -460,10 +460,10 @@ type PersistentVolumeClaimSpec struct { VolumeMode *PersistentVolumeMode `json:"volumeMode,omitempty" protobuf:"bytes,6,opt,name=volumeMode,casttype=PersistentVolumeMode"` // If specified, volume will be prepopulated with data from the specified data source. // This depends on the provisioner for this volume being able to use the specified source. - // If the provisioner failed to populate the volume with the source, it will return an - // error and fail the create volume operation. If the provisioner does not support the - // data source, it will also return an error and fail the create volume operation. - // It requires the VolumeSnapshotDataSource alpha feature gate to be enabled and + // If the provisioner failed to create volume from the data source, the behavior will be + // the same as the no data source case. In this failure case, PV will not be created, PVC + // will be in the pending state, and the controller will keep retrying to create the volume. + // This requires the VolumeSnapshotDataSource alpha feature gate to be enabled and // currently VolumeSnapshot is the only supported data source. // In the future, we will allow more data source types when new feature is ready. // +optional