github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 03:11:40 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #62067 from shyamjvs/fix-metrics-printing-bug-in-density

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 60983, 62012, 61892, 62051, 62067). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Don't quit without printing API latencies in density test if it failed

This is the reason why we are missing quite some data points in our perf-dash graphs for density test (as I mentioned in https://github.com/kubernetes/kubernetes/issues/62064#issuecomment-378235194)

```release-note
NONE
```

/cc @wojtek-t
This commit is contained in:
Kubernetes Submit Queue 2018-04-03 11:33:22 -07:00 committed by GitHub
commit 9c40f5b5a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/e2e/scalability/density.go
View File

@ -386,7 +386,6 @@ var _ = SIGDescribe("Density", func() {
framework.ExpectNoError(err) framework.ExpectNoError(err)
if err == nil { if err == nil {
summaries = append(summaries, metrics) summaries = append(summaries, metrics)
Expect(highLatencyRequests).NotTo(BeNumerically(">", 0), "There should be no high-latency requests")
} }
// Verify scheduler metrics. // Verify scheduler metrics.
@ -401,6 +400,8 @@ var _ = SIGDescribe("Density", func() {
framework.PrintSummaries(summaries, testCaseBaseName) framework.PrintSummaries(summaries, testCaseBaseName)
// Fail if there were some high-latency requests.
Expect(highLatencyRequests).NotTo(BeNumerically(">", 0), "There should be no high-latency requests")
// Fail if more than the allowed threshold of measurements were missing in the latencyTest. // Fail if more than the allowed threshold of measurements were missing in the latencyTest.
Expect(missingMeasurements <= MaxMissingPodStartupMeasurements).To(Equal(true)) Expect(missingMeasurements <= MaxMissingPodStartupMeasurements).To(Equal(true))
}) })