From 1842922b6b553bc810961243ec747b1aa91cdd25 Mon Sep 17 00:00:00 2001 From: Yu-Ju Hong Date: Fri, 27 Oct 2017 15:08:09 -0700 Subject: [PATCH 1/2] GCE: provide an option to disable docker's live-restore --- cluster/gce/config-default.sh | 6 +++++- cluster/gce/config-test.sh | 5 +++++ cluster/gce/gci/configure-helper.sh | 6 ++++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/cluster/gce/config-default.sh b/cluster/gce/config-default.sh index 3d95db434ec..569a20be127 100755 --- a/cluster/gce/config-default.sh +++ b/cluster/gce/config-default.sh @@ -254,12 +254,16 @@ if [ ${ENABLE_IP_ALIASES} = true ]; then PROVIDER_VARS="${PROVIDER_VARS:-} ENABLE_IP_ALIASES" fi - # Enable GCE Alpha features. if [[ -n "${GCE_ALPHA_FEATURES:-}" ]]; then PROVIDER_VARS="${PROVIDER_VARS:-} GCE_ALPHA_FEATURES" fi +# Disable Docker live-restore. +if [[ -n "${DISABLE_DOCKER_LIVE_RESTORE:-}" ]]; then + PROVIDER_VARS="${PROVIDER_VARS:-} DISABLE_DOCKER_LIVE_RESTORE" +fi + # Override default GLBC image if [[ -n "${GCE_GLBC_IMAGE:-}" ]]; then PROVIDER_VARS="${PROVIDER_VARS:-} GCE_GLBC_IMAGE" diff --git a/cluster/gce/config-test.sh b/cluster/gce/config-test.sh index aed8d3ea673..428a6dd0bac 100755 --- a/cluster/gce/config-test.sh +++ b/cluster/gce/config-test.sh @@ -302,6 +302,11 @@ if [[ -n "${GCE_ALPHA_FEATURES:-}" ]]; then PROVIDER_VARS="${PROVIDER_VARS:-} GCE_ALPHA_FEATURES" fi +# Disable Docker live-restore. +if [[ -n "${DISABLE_DOCKER_LIVE_RESTORE:-}" ]]; then + PROVIDER_VARS="${PROVIDER_VARS:-} DISABLE_DOCKER_LIVE_RESTORE" +fi + # Override default GLBC image if [[ -n "${GCE_GLBC_IMAGE:-}" ]]; then PROVIDER_VARS="${PROVIDER_VARS:-} GCE_GLBC_IMAGE" diff --git a/cluster/gce/gci/configure-helper.sh b/cluster/gce/gci/configure-helper.sh index 63d5b8c2f31..c7259b8f526 100644 --- a/cluster/gce/gci/configure-helper.sh +++ b/cluster/gce/gci/configure-helper.sh @@ -855,6 +855,12 @@ function assemble-docker-flags { docker_opts+=" --log-opt=max-size=${DOCKER_LOG_MAX_SIZE:-10m}" docker_opts+=" --log-opt=max-file=${DOCKER_LOG_MAX_FILE:-5}" + # Disable live-restore if the environment variable is set. + + if [[ "${DISABLE_DOCKER_LIVE_RESTORE:-false}" == "true" ]]; then + docker_opts+=" --live-restore=false" + fi + echo "DOCKER_OPTS=\"${docker_opts} ${EXTRA_DOCKER_OPTS:-}\"" > /etc/default/docker if [[ "${use_net_plugin}" == "true" ]]; then From 99b9c3d26ce8e82e5fe84edf413fc4f6bfde263f Mon Sep 17 00:00:00 2001 From: Yu-Ju Hong Date: Tue, 7 Nov 2017 15:27:56 -0800 Subject: [PATCH 2/2] Dockershim: print docker info output at startup --- pkg/kubelet/dockershim/docker_service.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/kubelet/dockershim/docker_service.go b/pkg/kubelet/dockershim/docker_service.go index b7ef158a5d4..b8525de17de 100644 --- a/pkg/kubelet/dockershim/docker_service.go +++ b/pkg/kubelet/dockershim/docker_service.go @@ -202,6 +202,7 @@ func NewDockerService(client libdocker.Interface, podSandboxImage string, stream // NOTE: cgroup driver is only detectable in docker 1.11+ cgroupDriver := defaultCgroupDriver dockerInfo, err := ds.client.Info() + glog.Infof("Docker Info: %+v", dockerInfo) if err != nil { glog.Errorf("Failed to execute Info() call to the Docker client: %v", err) glog.Warningf("Falling back to use the default driver: %q", cgroupDriver)