github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-22 10:27:56 +00:00
Code Issues Projects Releases Wiki Activity

Add metrics for force cleaned mounts after failed reconstruction

Browse Source 
Count nr. of force cleaned mounts + their failures after a volume fails
reconstruction.
This commit is contained in:
Jan Safranek
2023-02-22 13:00:35 +01:00
parent bd73aee9db
commit 9ca548fcf0
2 changed files with 32 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kubelet/volumemanager/reconciler/reconstruct_common.go
View File

@@ -95,10 +95,12 @@ func (rc *reconciler) cleanupMounts(volume podVolume) {
PluginName: volume.pluginName,
PodUID: types.UID(volume.podName),
}
metrics.ForceCleanedFailedVolumeOperationsTotal.Inc()
// TODO: Currently cleanupMounts only includes UnmountVolume operation. In the next PR, we will add
// to unmount both volume and device in the same routine.
err := rc.operationExecutor.UnmountVolume(mountedVolume, rc.actualStateOfWorld, rc.kubeletPodsDir)
if err != nil {
metrics.ForceCleanedFailedVolumeOperationsErrorsTotal.Inc()
klog.ErrorS(err, mountedVolume.GenerateErrorDetailed("volumeHandler.UnmountVolumeHandler for UnmountVolume failed", err).Error())
return
}
@@ -179,10 +181,10 @@ func getVolumesFromPodDir(podDir string) ([]podVolume, error) {
// Reconstruct volume data structure by reading the pod's volume directories
func (rc *reconciler) reconstructVolume(volume podVolume) (rvolume *reconstructedVolume, rerr error) {
metrics.ReconstructedVolumesTotal.Inc()
metrics.ReconstructVolumeOperationsTotal.Inc()
defer func() {
if rerr != nil {
metrics.ReconstructedVolumesErrorsTotal.Inc()
metrics.ReconstructVolumeOperationsErrorsTotal.Inc()
}
}()