github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 01:06:27 +00:00
Code Issues Projects Releases Wiki Activity

e2e: check return values in resize_nodes

Browse Source 
We weren't actually testing the return values in resize_nodes; and
I don't believe that was deliberate.
This commit is contained in:
Justin Santa Barbara 2015-07-06 08:33:46 -04:00
parent 638a19eb29
commit 9cd746e74d
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/e2e/resize_nodes.go
View File

@ -376,7 +376,9 @@ func performTemporaryNetworkFailure(c *client.Client, ns, rcName string, replica
}() }()
Logf("Waiting for node %s to be ready", node.Name) Logf("Waiting for node %s to be ready", node.Name)
waitForNodeToBe(c, node.Name, true, 2*time.Minute) if !waitForNodeToBe(c, node.Name, true, 2*time.Minute) {
Failf("Node did not become ready")
}
// The command will block all outgoing network traffic from the node to the master // The command will block all outgoing network traffic from the node to the master
// When multi-master is implemented, this test will have to be improved to block // When multi-master is implemented, this test will have to be improved to block
@ -390,13 +392,16 @@ func performTemporaryNetworkFailure(c *client.Client, ns, rcName string, replica
} }
Logf("Waiting for node %s to be not ready", node.Name) Logf("Waiting for node %s to be not ready", node.Name)
waitForNodeToBe(c, node.Name, false, 2*time.Minute) if !waitForNodeToBe(c, node.Name, false, 2*time.Minute) {
Failf("Node did not become not-ready")
}
Logf("Waiting for pod %s to be removed", podNameToDisappear) Logf("Waiting for pod %s to be removed", podNameToDisappear)
waitForRCPodToDisappear(c, ns, rcName, podNameToDisappear) err := waitForRCPodToDisappear(c, ns, rcName, podNameToDisappear)
Expect(err).NotTo(HaveOccurred())
By("verifying whether the pod from the unreachable node is recreated") By("verifying whether the pod from the unreachable node is recreated")
err := verifyPods(c, ns, rcName, true, replicas) err = verifyPods(c, ns, rcName, true, replicas)
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
// network traffic is unblocked in a deferred function // network traffic is unblocked in a deferred function
@ -539,7 +544,9 @@ var _ = Describe("Nodes", func() {
By(fmt.Sprintf("block network traffic from node %s", node.Name)) By(fmt.Sprintf("block network traffic from node %s", node.Name))
performTemporaryNetworkFailure(c, ns, name, replicas, pods.Items[0].Name, node) performTemporaryNetworkFailure(c, ns, name, replicas, pods.Items[0].Name, node)
Logf("Waiting for node %s to be ready", node.Name) Logf("Waiting for node %s to be ready", node.Name)
waitForNodeToBe(c, node.Name, true, 2*time.Minute) if !waitForNodeToBe(c, node.Name, true, 2*time.Minute) {
Failf("Node did not become ready")
}
By("verify whether new pods can be created on the re-attached node") By("verify whether new pods can be created on the re-attached node")
// increasing the RC size is not a valid way to test this // increasing the RC size is not a valid way to test this