mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-23 11:50:44 +00:00
kubeadm: Avoid unneeded dependencies by not using GetFlagString
Using GetFlagString from k8s.io/kubernetes/pkg/kubectl/cmd/util causes pkg/client/clientset_generated/internalclientset to be pulled as an external dependency, thus producing larger executable and increasing the maintainance hell. Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
This commit is contained in:
parent
a481f4bbe8
commit
9cef24901d
@ -52,7 +52,6 @@ go_library(
|
||||
"//cmd/kubeadm/app/util/kubeconfig:go_default_library",
|
||||
"//cmd/kubeadm/app/util/token:go_default_library",
|
||||
"//pkg/apis/core:go_default_library",
|
||||
"//pkg/kubectl/cmd/util:go_default_library",
|
||||
"//pkg/kubectl/util/i18n:go_default_library",
|
||||
"//pkg/util/initsystem:go_default_library",
|
||||
"//pkg/util/node:go_default_library",
|
||||
|
@ -27,7 +27,6 @@ import (
|
||||
|
||||
apimachineryversion "k8s.io/apimachinery/pkg/version"
|
||||
kubeadmutil "k8s.io/kubernetes/cmd/kubeadm/app/util"
|
||||
cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
|
||||
"k8s.io/kubernetes/pkg/kubectl/util/i18n"
|
||||
"k8s.io/kubernetes/pkg/version"
|
||||
)
|
||||
@ -60,7 +59,13 @@ func RunVersion(out io.Writer, cmd *cobra.Command) error {
|
||||
ClientVersion: &clientVersion,
|
||||
}
|
||||
|
||||
switch of := cmdutil.GetFlagString(cmd, "output"); of {
|
||||
const flag = "output"
|
||||
of, err := cmd.Flags().GetString(flag)
|
||||
if err != nil {
|
||||
glog.Fatalf("error accessing flag %s for command %s: %v", flag, cmd.Name(), err)
|
||||
}
|
||||
|
||||
switch of {
|
||||
case "":
|
||||
fmt.Fprintf(out, "kubeadm version: %#v\n", v.ClientVersion)
|
||||
case "short":
|
||||
|
Loading…
Reference in New Issue
Block a user