From 9d304774d462db23901b8af5b17dc087b65505cd Mon Sep 17 00:00:00 2001 From: Eric Paris Date: Tue, 26 May 2015 19:21:08 -0400 Subject: [PATCH] report glog error if unable to tell systemd things worked --- cmd/kube-apiserver/app/server.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/cmd/kube-apiserver/app/server.go b/cmd/kube-apiserver/app/server.go index af1a08c33e3..67b515d304c 100644 --- a/cmd/kube-apiserver/app/server.go +++ b/cmd/kube-apiserver/app/server.go @@ -456,7 +456,10 @@ func (s *APIServer) Run(_ []string) error { glog.Infof("Using self-signed cert (%s, %s)", s.TLSCertFile, s.TLSPrivateKeyFile) } } - _ = systemd.SdNotify("READY=1\n") + // err == systemd.SdNotifyNoSocket when not running on a systemd system + if err := systemd.SdNotify("READY=1\n"); err != nil && err != systemd.SdNotifyNoSocket { + glog.Errorf("Unable to send systemd daemon sucessful start message: %v\n", err) + } if err := secureServer.ListenAndServeTLS(s.TLSCertFile, s.TLSPrivateKeyFile); err != nil { glog.Errorf("Unable to listen for secure (%v); will try again.", err) } @@ -472,7 +475,10 @@ func (s *APIServer) Run(_ []string) error { MaxHeaderBytes: 1 << 20, } if secureLocation == "" { - _ = systemd.SdNotify("READY=1\n") + // err == systemd.SdNotifyNoSocket when not running on a systemd system + if err := systemd.SdNotify("READY=1\n"); err != nil && err != systemd.SdNotifyNoSocket { + glog.Errorf("Unable to send systemd daemon sucessful start message: %v\n", err) + } } glog.Infof("Serving insecurely on %s", insecureLocation) glog.Fatal(http.ListenAndServe())