github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 20:24:09 +00:00
Code Issues Projects Releases Wiki Activity

Be sure we delete the dummy tests.

Browse Source
This commit is contained in:
Katharine Berry 2018-08-30 16:57:10 -07:00
parent 8fe6467013
commit 9d499cd005
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hack/lib/golang.sh
View File

@ -496,9 +496,10 @@ EOF
# Argument: the name of a Kubernetes package (e.g. k8s.io/kubernetes/cmd/kube-scheduler). # Argument: the name of a Kubernetes package (e.g. k8s.io/kubernetes/cmd/kube-scheduler).
# Deletes a test generated by kube::golang::create_coverage_dummy_test. # Deletes a test generated by kube::golang::create_coverage_dummy_test.
# It is not an error to call this for a nonexistent test.
kube::golang::delete_coverage_dummy_test() { kube::golang::delete_coverage_dummy_test() {
local package="$1" local package="$1"
rm $(kube::golang::path_for_coverage_dummy_test "${package}") rm -f $(kube::golang::path_for_coverage_dummy_test "${package}")
} }
# Arguments: a list of kubernetes packages to build. # Arguments: a list of kubernetes packages to build.
@ -515,14 +516,16 @@ kube::golang::build_some_binaries() {
for package in "$@"; do for package in "$@"; do
if kube::golang::is_covered_binary "${package}"; then if kube::golang::is_covered_binary "${package}"; then
V=2 kube::log::info "Building ${package} with coverage..." V=2 kube::log::info "Building ${package} with coverage..."
kube::golang::create_coverage_dummy_test "${package}" kube::golang::create_coverage_dummy_test "${package}"
kube::util::trap_add "kube::golang::delete_coverage_dummy_test \"${package}\"" EXIT
go test -c -o "$(kube::golang::outfile_for_binary "${package}" "${platform}")" \ go test -c -o "$(kube::golang::outfile_for_binary "${package}" "${platform}")" \
-covermode count \ -covermode count \
-coverpkg k8s.io/... \ -coverpkg k8s.io/... \
"${build_args[@]}" \ "${build_args[@]}" \
-tags coverage \ -tags coverage \
"${package}" "${package}"
kube::golang::delete_coverage_dummy_test "${package}"
else else
uncovered+=("${package}") uncovered+=("${package}")
fi fi