github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 11:21:47 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #116066 from yoongon/feature/fit-test-comments

Browse Source 
Fix comments at fit_test.go to increase redability
This commit is contained in:
Kubernetes Prow Robot 2023-03-06 20:52:16 -08:00 committed by GitHub
commit 9d7db70882
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/scheduler/framework/plugins/noderesources/fit_test.go
View File

@ -535,25 +535,25 @@ func TestNotEnoughRequests(t *testing.T) {
{ {
pod: &v1.Pod{}, pod: &v1.Pod{},
nodeInfo: framework.NewNodeInfo(newResourcePod(framework.Resource{MilliCPU: 10, Memory: 20})), nodeInfo: framework.NewNodeInfo(newResourcePod(framework.Resource{MilliCPU: 10, Memory: 20})),
name: "even without specified resources predicate fails when there's no space for additional pod", name: "even without specified resources, predicate fails when there's no space for additional pod",
wantStatus: framework.NewStatus(framework.Unschedulable, "Too many pods"), wantStatus: framework.NewStatus(framework.Unschedulable, "Too many pods"),
}, },
{ {
pod: newResourcePod(framework.Resource{MilliCPU: 1, Memory: 1}), pod: newResourcePod(framework.Resource{MilliCPU: 1, Memory: 1}),
nodeInfo: framework.NewNodeInfo(newResourcePod(framework.Resource{MilliCPU: 5, Memory: 5})), nodeInfo: framework.NewNodeInfo(newResourcePod(framework.Resource{MilliCPU: 5, Memory: 5})),
name: "even if both resources fit predicate fails when there's no space for additional pod", name: "even if both resources fit, predicate fails when there's no space for additional pod",
wantStatus: framework.NewStatus(framework.Unschedulable, "Too many pods"), wantStatus: framework.NewStatus(framework.Unschedulable, "Too many pods"),
}, },
{ {
pod: newResourcePod(framework.Resource{MilliCPU: 5, Memory: 1}), pod: newResourcePod(framework.Resource{MilliCPU: 5, Memory: 1}),
nodeInfo: framework.NewNodeInfo(newResourcePod(framework.Resource{MilliCPU: 5, Memory: 19})), nodeInfo: framework.NewNodeInfo(newResourcePod(framework.Resource{MilliCPU: 5, Memory: 19})),
name: "even for equal edge case predicate fails when there's no space for additional pod", name: "even for equal edge case, predicate fails when there's no space for additional pod",
wantStatus: framework.NewStatus(framework.Unschedulable, "Too many pods"), wantStatus: framework.NewStatus(framework.Unschedulable, "Too many pods"),
}, },
{ {
pod: newResourceInitPod(newResourcePod(framework.Resource{MilliCPU: 5, Memory: 1}), framework.Resource{MilliCPU: 5, Memory: 1}), pod: newResourceInitPod(newResourcePod(framework.Resource{MilliCPU: 5, Memory: 1}), framework.Resource{MilliCPU: 5, Memory: 1}),
nodeInfo: framework.NewNodeInfo(newResourcePod(framework.Resource{MilliCPU: 5, Memory: 19})), nodeInfo: framework.NewNodeInfo(newResourcePod(framework.Resource{MilliCPU: 5, Memory: 19})),
name: "even for equal edge case predicate fails when there's no space for additional pod due to init container", name: "even for equal edge case, predicate fails when there's no space for additional pod due to init container",
wantStatus: framework.NewStatus(framework.Unschedulable, "Too many pods"), wantStatus: framework.NewStatus(framework.Unschedulable, "Too many pods"),
}, },
} }
@ -588,18 +588,11 @@ func TestStorageRequests(t *testing.T) {
name string name string
wantStatus *framework.Status wantStatus *framework.Status
}{ }{
{
pod: newResourcePod(framework.Resource{MilliCPU: 1, Memory: 1}),
nodeInfo: framework.NewNodeInfo(
newResourcePod(framework.Resource{MilliCPU: 10, Memory: 10})),
name: "due to container scratch disk",
wantStatus: framework.NewStatus(framework.Unschedulable, getErrReason(v1.ResourceCPU)),
},
{ {
pod: newResourcePod(framework.Resource{MilliCPU: 1, Memory: 1}), pod: newResourcePod(framework.Resource{MilliCPU: 1, Memory: 1}),
nodeInfo: framework.NewNodeInfo( nodeInfo: framework.NewNodeInfo(
newResourcePod(framework.Resource{MilliCPU: 2, Memory: 10})), newResourcePod(framework.Resource{MilliCPU: 2, Memory: 10})),
name: "pod fit", name: "empty storage requested, and pod fits",
}, },
{ {
pod: newResourcePod(framework.Resource{EphemeralStorage: 25}), pod: newResourcePod(framework.Resource{EphemeralStorage: 25}),