kubectl rollout: support recursive flag for rollout status

This commit is contained in:
Philip Ottesen 2022-03-17 15:41:10 -04:00 committed by Philip Ottesen
parent f173d01c01
commit 9d8286c82c

View File

@ -168,73 +168,67 @@ func (o *RolloutStatusOptions) Run() error {
LabelSelectorParam(o.LabelSelector). LabelSelectorParam(o.LabelSelector).
FilenameParam(o.EnforceNamespace, o.FilenameOptions). FilenameParam(o.EnforceNamespace, o.FilenameOptions).
ResourceTypeOrNameArgs(true, o.BuilderArgs...). ResourceTypeOrNameArgs(true, o.BuilderArgs...).
SingleResourceType(). ContinueOnError().
Latest(). Latest().
Do() Do()
err := r.Err() err := r.Err()
if err != nil { if err != nil {
return err return err
} }
infos, err := r.Infos() return r.Visit(func(info *resource.Info, err error) error {
if err != nil { mapping := info.ResourceMapping()
return err statusViewer, err := o.StatusViewerFn(mapping)
} if err != nil {
if len(infos) != 1 { return err
return fmt.Errorf("rollout status is only supported on individual resources and resource collections - %d resources were found", len(infos)) }
}
info := infos[0]
mapping := info.ResourceMapping()
statusViewer, err := o.StatusViewerFn(mapping) fieldSelector := fields.OneTermEqualSelector("metadata.name", info.Name).String()
if err != nil { lw := &cache.ListWatch{
return err ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {
} options.FieldSelector = fieldSelector
return o.DynamicClient.Resource(info.Mapping.Resource).Namespace(info.Namespace).List(context.TODO(), options)
},
WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) {
options.FieldSelector = fieldSelector
return o.DynamicClient.Resource(info.Mapping.Resource).Namespace(info.Namespace).Watch(context.TODO(), options)
},
}
fieldSelector := fields.OneTermEqualSelector("metadata.name", info.Name).String() // if the rollout isn't done yet, keep watching deployment status
lw := &cache.ListWatch{ ctx, cancel := watchtools.ContextWithOptionalTimeout(context.Background(), o.Timeout)
ListFunc: func(options metav1.ListOptions) (runtime.Object, error) { intr := interrupt.New(nil, cancel)
options.FieldSelector = fieldSelector return intr.Run(func() error {
return o.DynamicClient.Resource(info.Mapping.Resource).Namespace(info.Namespace).List(context.TODO(), options) _, err = watchtools.UntilWithSync(ctx, lw, &unstructured.Unstructured{}, nil, func(e watch.Event) (bool, error) {
}, switch t := e.Type; t {
WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) { case watch.Added, watch.Modified:
options.FieldSelector = fieldSelector status, done, err := statusViewer.Status(e.Object.(runtime.Unstructured), o.Revision)
return o.DynamicClient.Resource(info.Mapping.Resource).Namespace(info.Namespace).Watch(context.TODO(), options) if err != nil {
}, return false, err
} }
fmt.Fprintf(o.Out, "%s", status)
// Quit waiting if the rollout is done
if done {
return true, nil
}
// if the rollout isn't done yet, keep watching deployment status shouldWatch := o.Watch
ctx, cancel := watchtools.ContextWithOptionalTimeout(context.Background(), o.Timeout) if !shouldWatch {
intr := interrupt.New(nil, cancel) return true, nil
return intr.Run(func() error { }
_, err = watchtools.UntilWithSync(ctx, lw, &unstructured.Unstructured{}, nil, func(e watch.Event) (bool, error) {
switch t := e.Type; t { return false, nil
case watch.Added, watch.Modified:
status, done, err := statusViewer.Status(e.Object.(runtime.Unstructured), o.Revision) case watch.Deleted:
if err != nil { // We need to abort to avoid cases of recreation and not to silently watch the wrong (new) object
return false, err return true, fmt.Errorf("object has been deleted")
default:
return true, fmt.Errorf("internal error: unexpected event %#v", e)
} }
fmt.Fprintf(o.Out, "%s", status) })
// Quit waiting if the rollout is done return err
if done {
return true, nil
}
shouldWatch := o.Watch
if !shouldWatch {
return true, nil
}
return false, nil
case watch.Deleted:
// We need to abort to avoid cases of recreation and not to silently watch the wrong (new) object
return true, fmt.Errorf("object has been deleted")
default:
return true, fmt.Errorf("internal error: unexpected event %#v", e)
}
}) })
return err
}) })
} }