From 9d893c83f01484c92213a4aa374b139225a36df7 Mon Sep 17 00:00:00 2001 From: Ed Bartosh Date: Thu, 1 Aug 2024 23:56:38 +0300 Subject: [PATCH] DRA: fix failing test Added error assertion for NodePrepareResources call unveiled "rpc error: code = DeadlineExceeded desc = context deadline exceeded" failure in the TestGRPCConnIsReused test. Setting clientCallTimeout field when creating plugin should fix it. --- pkg/kubelet/cm/dra/plugin/client_test.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/kubelet/cm/dra/plugin/client_test.go b/pkg/kubelet/cm/dra/plugin/client_test.go index 6ce09b5a5a4..97e948a31b5 100644 --- a/pkg/kubelet/cm/dra/plugin/client_test.go +++ b/pkg/kubelet/cm/dra/plugin/client_test.go @@ -109,8 +109,9 @@ func TestGRPCConnIsReused(t *testing.T) { m := sync.Mutex{} p := &Plugin{ - backgroundCtx: ctx, - endpoint: addr, + backgroundCtx: ctx, + endpoint: addr, + clientCallTimeout: defaultClientCallTimeout, } conn, err := p.getOrCreateGRPCConn() @@ -148,7 +149,8 @@ func TestGRPCConnIsReused(t *testing.T) { }, }, } - client.NodePrepareResources(context.TODO(), req) + _, err = client.NodePrepareResources(context.TODO(), req) + assert.NoError(t, err) client.mutex.Lock() conn := client.conn