From 9e1d6d5cdc14fd803c6bd91005ddfdd7da5f1790 Mon Sep 17 00:00:00 2001 From: Swati Sehgal Date: Wed, 12 Feb 2025 16:31:48 +0000 Subject: [PATCH] node: topology-mgr: Add logs in the happy path Signed-off-by: Swati Sehgal --- pkg/kubelet/cm/topologymanager/scope_container.go | 3 ++- pkg/kubelet/cm/topologymanager/scope_pod.go | 1 + pkg/kubelet/cm/topologymanager/topology_manager.go | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/kubelet/cm/topologymanager/scope_container.go b/pkg/kubelet/cm/topologymanager/scope_container.go index 3cea962310c..7bdbba68dc2 100644 --- a/pkg/kubelet/cm/topologymanager/scope_container.go +++ b/pkg/kubelet/cm/topologymanager/scope_container.go @@ -17,7 +17,7 @@ limitations under the License. package topologymanager import ( - "k8s.io/api/core/v1" + "k8s.io/api/core/v1" "k8s.io/klog/v2" "k8s.io/kubernetes/pkg/kubelet/cm/admission" "k8s.io/kubernetes/pkg/kubelet/cm/containermap" @@ -63,6 +63,7 @@ func (s *containerScope) Admit(pod *v1.Pod) lifecycle.PodAdmitResult { } if IsAlignmentGuaranteed(s.policy) { + klog.V(4).InfoS("Resource alignment at container scope guaranteed", "pod", klog.KObj(pod)) metrics.ContainerAlignedComputeResources.WithLabelValues(metrics.AlignScopeContainer, metrics.AlignedNUMANode).Inc() } } diff --git a/pkg/kubelet/cm/topologymanager/scope_pod.go b/pkg/kubelet/cm/topologymanager/scope_pod.go index a2d28d07778..d06d9578256 100644 --- a/pkg/kubelet/cm/topologymanager/scope_pod.go +++ b/pkg/kubelet/cm/topologymanager/scope_pod.go @@ -64,6 +64,7 @@ func (s *podScope) Admit(pod *v1.Pod) lifecycle.PodAdmitResult { } if IsAlignmentGuaranteed(s.policy) { // increment only if we know we allocate aligned resources. + klog.V(4).InfoS("Resource alignment at pod scope guaranteed", "pod", klog.KObj(pod)) metrics.ContainerAlignedComputeResources.WithLabelValues(metrics.AlignScopePod, metrics.AlignedNUMANode).Inc() } return admission.GetPodAdmitResult(nil) diff --git a/pkg/kubelet/cm/topologymanager/topology_manager.go b/pkg/kubelet/cm/topologymanager/topology_manager.go index 7c5e9d3d8cc..d9e244952ec 100644 --- a/pkg/kubelet/cm/topologymanager/topology_manager.go +++ b/pkg/kubelet/cm/topologymanager/topology_manager.go @@ -212,11 +212,13 @@ func (m *manager) RemoveContainer(containerID string) error { } func (m *manager) Admit(attrs *lifecycle.PodAdmitAttributes) lifecycle.PodAdmitResult { + klog.V(4).InfoS("Topology manager admission check", "pod", klog.KObj(attrs.Pod)) metrics.TopologyManagerAdmissionRequestsTotal.Inc() startTime := time.Now() podAdmitResult := m.scope.Admit(attrs.Pod) metrics.TopologyManagerAdmissionDuration.Observe(float64(time.Since(startTime).Milliseconds())) + klog.V(4).InfoS("Pod Admit Result", "Message", podAdmitResult.Message, "pod", klog.KObj(attrs.Pod)) return podAdmitResult }