From 07029c941a2d69e90317f8fa8089f5ac72f61065 Mon Sep 17 00:00:00 2001 From: Mike Dame Date: Wed, 21 Apr 2021 15:58:00 -0400 Subject: [PATCH] Remove Limits from scheduling e2e balanced pod resources The purpose of the pod created by `createBalancedPodForNodes()` is to ensure that all nodes have equal resource requests (as seen by the scheduler). This prevents the default scheduling behavior (which attempts to balance resource requests) from interfering with e2e's which test other priorities/score plugins. Because the scheduler only worries about requests, specifying `Limits` in this pod is unnecessary. In fact, if the calculated "balancing" limit is too low, it can cause the balancing pod to never start due to OOMKill errors, leading to flakes and failures. --- test/e2e/scheduling/priorities.go | 1 - 1 file changed, 1 deletion(-) diff --git a/test/e2e/scheduling/priorities.go b/test/e2e/scheduling/priorities.go index a0dc8c8eb15..9a5696aa8fa 100644 --- a/test/e2e/scheduling/priorities.go +++ b/test/e2e/scheduling/priorities.go @@ -550,7 +550,6 @@ func createBalancedPodForNodes(f *framework.Framework, cs clientset.Interface, n Name: "", Labels: balancePodLabel, Resources: &v1.ResourceRequirements{ - Limits: needCreateResource, Requests: needCreateResource, }, Affinity: &v1.Affinity{