add UT for pkg/kubecl clusterrolebinding

This commit is contained in:
m1093782566
2017-08-03 16:33:10 +08:00
parent 2495cc602f
commit 9eab16f10e
3 changed files with 244 additions and 12 deletions

View File

@@ -21,9 +21,9 @@ import (
"strings"
rbacv1beta1 "k8s.io/api/rbac/v1beta1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/kubernetes/pkg/apis/rbac"
)
// ClusterRoleBindingGeneratorV1 supports stable generation of a clusterRoleBinding.
@@ -109,24 +109,24 @@ func (s ClusterRoleBindingGeneratorV1) StructuredGenerate() (runtime.Object, err
if err := s.validate(); err != nil {
return nil, err
}
clusterRoleBinding := &rbac.ClusterRoleBinding{}
clusterRoleBinding := &rbacv1beta1.ClusterRoleBinding{}
clusterRoleBinding.Name = s.Name
clusterRoleBinding.RoleRef = rbac.RoleRef{
APIGroup: rbac.GroupName,
clusterRoleBinding.RoleRef = rbacv1beta1.RoleRef{
APIGroup: rbacv1beta1.GroupName,
Kind: "ClusterRole",
Name: s.ClusterRole,
}
for _, user := range sets.NewString(s.Users...).List() {
clusterRoleBinding.Subjects = append(clusterRoleBinding.Subjects, rbac.Subject{
Kind: rbac.UserKind,
APIGroup: rbac.GroupName,
clusterRoleBinding.Subjects = append(clusterRoleBinding.Subjects, rbacv1beta1.Subject{
Kind: rbacv1beta1.UserKind,
APIGroup: rbacv1beta1.GroupName,
Name: user,
})
}
for _, group := range sets.NewString(s.Groups...).List() {
clusterRoleBinding.Subjects = append(clusterRoleBinding.Subjects, rbac.Subject{
Kind: rbac.GroupKind,
APIGroup: rbac.GroupName,
clusterRoleBinding.Subjects = append(clusterRoleBinding.Subjects, rbacv1beta1.Subject{
Kind: rbacv1beta1.GroupKind,
APIGroup: rbacv1beta1.GroupName,
Name: group,
})
}
@@ -135,8 +135,8 @@ func (s ClusterRoleBindingGeneratorV1) StructuredGenerate() (runtime.Object, err
if len(tokens) != 2 || tokens[0] == "" || tokens[1] == "" {
return nil, fmt.Errorf("serviceaccount must be <namespace>:<name>")
}
clusterRoleBinding.Subjects = append(clusterRoleBinding.Subjects, rbac.Subject{
Kind: rbac.ServiceAccountKind,
clusterRoleBinding.Subjects = append(clusterRoleBinding.Subjects, rbacv1beta1.Subject{
Kind: rbacv1beta1.ServiceAccountKind,
APIGroup: "",
Namespace: tokens[0],
Name: tokens[1],