From 9ebd872e7179b080818c315449ee6f96a678df30 Mon Sep 17 00:00:00 2001 From: Dave Chen Date: Wed, 17 Jun 2020 15:11:44 +0800 Subject: [PATCH] Explicitly declare the interfaces for extension points This make it easier to catch the issue during the compilation, also, this also align with other plugins, i.e. plugin of "InterPodAffinity". Signed-off-by: Dave Chen --- .../defaultpodtopologyspread/default_pod_topology_spread.go | 1 + pkg/scheduler/framework/plugins/nodeports/node_ports.go | 1 + 2 files changed, 2 insertions(+) diff --git a/pkg/scheduler/framework/plugins/defaultpodtopologyspread/default_pod_topology_spread.go b/pkg/scheduler/framework/plugins/defaultpodtopologyspread/default_pod_topology_spread.go index d93264745db..15d24e72d25 100644 --- a/pkg/scheduler/framework/plugins/defaultpodtopologyspread/default_pod_topology_spread.go +++ b/pkg/scheduler/framework/plugins/defaultpodtopologyspread/default_pod_topology_spread.go @@ -33,6 +33,7 @@ type DefaultPodTopologySpread struct { handle framework.FrameworkHandle } +var _ framework.PreScorePlugin = &DefaultPodTopologySpread{} var _ framework.ScorePlugin = &DefaultPodTopologySpread{} const ( diff --git a/pkg/scheduler/framework/plugins/nodeports/node_ports.go b/pkg/scheduler/framework/plugins/nodeports/node_ports.go index a90b166ff43..f3332fff919 100644 --- a/pkg/scheduler/framework/plugins/nodeports/node_ports.go +++ b/pkg/scheduler/framework/plugins/nodeports/node_ports.go @@ -28,6 +28,7 @@ import ( // NodePorts is a plugin that checks if a node has free ports for the requested pod ports. type NodePorts struct{} +var _ framework.PreFilterPlugin = &NodePorts{} var _ framework.FilterPlugin = &NodePorts{} const (