github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #52544 from shyamjvs/increase-window-of-prometheus-metric

Browse Source 
Automatic merge from submit-queue

Increase sliding window to 5hr for request_latencies metric

We're seeing high latency values for a couple of types of api calls in our density test (ref https://github.com/kubernetes/kubernetes/issues/51899). And we're recording values from only the last 1 hour in the metric (as @wojtek-t told me offline) - so our test result is pretty much counting only the calls during the delete phase.

cc @kubernetes/sig-scalability-misc @kubernetes/sig-api-machinery-misc @gmarek
This commit is contained in:
Kubernetes Submit Queue 2017-09-15 09:19:06 -07:00 committed by GitHub
commit 9ef9a1b8f0
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
View File

@ -56,8 +56,9 @@ var (
prometheus.SummaryOpts{ prometheus.SummaryOpts{
Name: "apiserver_request_latencies_summary", Name: "apiserver_request_latencies_summary",
Help: "Response latency summary in microseconds for each verb, resource and subresource.", Help: "Response latency summary in microseconds for each verb, resource and subresource.",
// Make the sliding window of 1h. // Make the sliding window of 5h.
MaxAge: time.Hour, // TODO: The value for this should be based on our SLI definition (medium term).
MaxAge: 5 * time.Hour,
}, },
[]string{"verb", "resource", "subresource", "scope"}, []string{"verb", "resource", "subresource", "scope"},
) )