From 9f2a02a723473fcd2dfaa042c6cfe29226c3c178 Mon Sep 17 00:00:00 2001 From: Stephen Kitt Date: Thu, 3 Oct 2024 11:48:45 +0200 Subject: [PATCH] kubelet: validate service names with slashes Signed-off-by: Stephen Kitt --- pkg/kubelet/kubelet_server_journal_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/kubelet/kubelet_server_journal_test.go b/pkg/kubelet/kubelet_server_journal_test.go index 38f062c138b..94549be173b 100644 --- a/pkg/kubelet/kubelet_server_journal_test.go +++ b/pkg/kubelet/kubelet_server_journal_test.go @@ -136,6 +136,7 @@ func Test_validateServices(t *testing.T) { serviceColon = "svc:foo" invalidServiceNewline = "svc\n" invalidServiceNewlineDot = "svc.foo\n" + invalidServiceSlash = "svc/foo" ) tests := []struct { name string @@ -150,6 +151,7 @@ func Test_validateServices(t *testing.T) { {name: "colon service", services: []string{serviceColon}}, {name: "invalid service new line", services: []string{invalidServiceNewline}, wantErr: true}, {name: "invalid service with dot", services: []string{invalidServiceNewlineDot}, wantErr: true}, + {name: "invalid service with slash", services: []string{invalidServiceSlash}, wantErr: true}, {name: "long service", services: []string{strings.Repeat(service1, 100)}, wantErr: true}, {name: "max number of services", services: []string{service1, service2, serviceDot, serviceUnderscore, serviceAt}, wantErr: true}, }