From b5889ee82c2c3cc64482e58e294ddb384dc3aac9 Mon Sep 17 00:00:00 2001 From: Yecheng Fu Date: Sun, 6 Oct 2019 14:29:59 +0800 Subject: [PATCH] update internal error message --- pkg/controller/volume/scheduling/scheduler_binder.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/pkg/controller/volume/scheduling/scheduler_binder.go b/pkg/controller/volume/scheduling/scheduler_binder.go index 3831aa0d43e..298ae211958 100644 --- a/pkg/controller/volume/scheduling/scheduler_binder.go +++ b/pkg/controller/volume/scheduling/scheduler_binder.go @@ -353,11 +353,7 @@ func (b *volumeBinder) BindPodVolumes(assumedPod *v1.Pod) (err error) { return b, err }) if err != nil { - pvcName := "" - if len(claimsToProvision) > 0 { - pvcName = claimsToProvision[0].Name - } - return fmt.Errorf("Failed to bind volumes: provisioning failed for PVC %q: %v", pvcName, err) + return fmt.Errorf("Failed to bind volumes: %v", err) } return nil } @@ -523,7 +519,10 @@ func (b *volumeBinder) checkBindings(pod *v1.Pod, bindings []*bindingInfo, claim } selectedNode := pvc.Annotations[pvutil.AnnSelectedNode] if selectedNode != pod.Spec.NodeName { - return false, fmt.Errorf("selectedNode annotation value %q not set to scheduled node %q", selectedNode, pod.Spec.NodeName) + // If provisioner fails to provision a volume, selectedNode + // annotation will be removed to signal back to the scheduler to + // retry. + return false, fmt.Errorf("provisioning failed for PVC %q", pvc.Name) } // If the PVC is bound to a PV, check its node affinity