github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 02:09:56 +00:00
Code Issues Projects Releases Wiki Activity

Stop fd leak in e2e_service.go

Browse Source 
Previously this code used http.Get and failed to read/close resp.Body, which
prevented network connection reuse, leaking fds. Now we use http.Head
instead, because its response always has a nil Body, so we don't have to
worry about read/close.
This commit is contained in:
Michael Taufen 2016-08-23 16:48:01 -07:00
parent 2e989a3c38
commit 9fdb3f291a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e_node/e2e_service.go
View File

@ -483,7 +483,7 @@ func readinessCheck(urls []string, errCh <-chan error) error {
case <-time.After(time.Second): case <-time.After(time.Second):
ready := true ready := true
for _, url := range urls { for _, url := range urls {
resp, err := http.Get(url) resp, err := http.Head(url)
if err != nil || resp.StatusCode != http.StatusOK { if err != nil || resp.StatusCode != http.StatusOK {
ready = false ready = false
break break
@ -580,7 +580,7 @@ func (s *server) start() error {
return return
case <-time.After(time.Second): case <-time.After(time.Second):
for _, url := range s.healthCheckUrls { for _, url := range s.healthCheckUrls {
resp, err := http.Get(url) resp, err := http.Head(url)
if err != nil || resp.StatusCode != http.StatusOK { if err != nil || resp.StatusCode != http.StatusOK {
break stillAlive break stillAlive
} }