From a77f4f4c29be1503b62273c053cba4b32aed9452 Mon Sep 17 00:00:00 2001 From: Elana Hashman Date: Fri, 30 Jul 2021 15:22:29 -0700 Subject: [PATCH] Log e2e-node kubelet output directly to file For some reason when we send them to journald, many log lines are consistently dropped as soon as the PLEG is started. If we log directly to file, we don't have this problem. As a bonus, if the tests crash, the kubelet logs will always be available since they were already written; otherwise we normally wait until the end of the test run to collect them from journald, meaning that we often end up with empty logs. --- test/e2e_node/services/kubelet.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/e2e_node/services/kubelet.go b/test/e2e_node/services/kubelet.go index 089620c3511..19344dce658 100644 --- a/test/e2e_node/services/kubelet.go +++ b/test/e2e_node/services/kubelet.go @@ -194,6 +194,7 @@ func (e *E2EServices) startKubelet() (*server, error) { cmdArgs = append(cmdArgs, systemdRun, "-p", "Delegate=true", + "-p", "StandardError=file:"+framework.TestContext.ReportDir+"/kubelet.log", "--unit="+unitName, "--slice=runtime.slice", "--remain-after-exit", @@ -201,10 +202,6 @@ func (e *E2EServices) startKubelet() (*server, error) { killCommand = exec.Command("systemctl", "kill", unitName) restartCommand = exec.Command("systemctl", "restart", unitName) - e.logs["kubelet.log"] = LogFileData{ - Name: "kubelet.log", - JournalctlCommand: []string{"-u", unitName}, - } kc.KubeletCgroups = "/kubelet.slice" kubeletConfigFlags = append(kubeletConfigFlags, "kubelet-cgroups")