From 387796307a9df52c8e22c2de5e2073d3366bb6ff Mon Sep 17 00:00:00 2001 From: Stephen Augustus Date: Mon, 25 Jan 2021 05:17:16 -0500 Subject: [PATCH 1/7] OWNERS(sig-release): Remove SIG Release approvers alias We're currently only using this for changelog approvals and those should really be handled by relnotes + RelEng. Signed-off-by: Stephen Augustus --- CHANGELOG/OWNERS | 1 - OWNERS_ALIASES | 5 ----- 2 files changed, 6 deletions(-) diff --git a/CHANGELOG/OWNERS b/CHANGELOG/OWNERS index da3c000a1f8..e6ea304a6fa 100644 --- a/CHANGELOG/OWNERS +++ b/CHANGELOG/OWNERS @@ -1,7 +1,6 @@ # See the OWNERS docs at https://go.k8s.io/owners approvers: - - sig-release-approvers - release-engineering-approvers reviewers: - release-engineering-reviewers diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 955c987e287..98c04e3bde8 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -116,11 +116,6 @@ aliases: - WanLinghao # SIG Release - sig-release-approvers: - - alejandrox1 # SIG Technical Lead - - justaugustus # SIG Chair - - saschagrunert # SIG Technical Lead - - tpepper # SIG Chair release-engineering-approvers: - alejandrox1 # SIG Technical Lead - justaugustus # SIG Chair From 2ba5d9991264f23b9271a1d6e0eb08113bc08a41 Mon Sep 17 00:00:00 2001 From: hasheddan Date: Mon, 4 Jan 2021 19:25:53 -0600 Subject: [PATCH 2/7] OWNERS(releng): Sync Release Managers Signed-off-by: hasheddan Co-authored-by: Stephen Augustus --- OWNERS_ALIASES | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 98c04e3bde8..04be2a1e384 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -117,18 +117,22 @@ aliases: # SIG Release release-engineering-approvers: - - alejandrox1 # SIG Technical Lead - - justaugustus # SIG Chair - - saschagrunert # SIG Technical Lead - - tpepper # SIG Chair + - cpanato # Release Manager + - feiskyer # Release Manager + - hasheddan # Release Manager / SIG Technical Lead + - idealhack # Release Manager + - justaugustus # Release Manager / SIG Chair + - puerco # Release Manager + - saschagrunert # Release Manager / SIG Chair + - xmudrii # Release Manager release-engineering-reviewers: - cpanato # Release Manager - feiskyer # Release Manager - - hasheddan # Release Manager - - hoegaarden # Release Manager - - justaugustus # SIG Chair / Release Manager - - saschagrunert # SIG Technical Lead / Release Manager - - tpepper # SIG Chair / Release Manager + - hasheddan # Release Manager / SIG Technical Lead + - idealhack # Release Manager + - justaugustus # Release Manager / SIG Chair + - puerco # Release Manager + - saschagrunert # Release Manager / SIG Chair - xmudrii # Release Manager build-image-approvers: - BenTheElder From a79a5f7d46672b538b46b17235e4f9ed9899bb10 Mon Sep 17 00:00:00 2001 From: Stephen Augustus Date: Mon, 25 Jan 2021 05:53:29 -0500 Subject: [PATCH 3/7] OWNERS(build-image): Add Release Managers as reviewers Signed-off-by: Stephen Augustus --- OWNERS_ALIASES | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 04be2a1e384..5107ce919ba 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -138,14 +138,21 @@ aliases: - BenTheElder - cblecker - dims - - justaugustus + - justaugustus # Release Manager / SIG Chair - listx build-image-reviewers: - BenTheElder - cblecker + - cpanato # Release Manager - dims - - justaugustus + - feiskyer # Release Manager + - hasheddan # Release Manager / SIG Technical Lead + - idealhack # Release Manager + - justaugustus # Release Manager / SIG Chair - listx + - puerco # Release Manager + - saschagrunert # Release Manager / SIG Chair + - xmudrii # Release Manager sig-storage-approvers: - saad-ali From 205b9d7703788d3f319af5f15ff79bb26ee3b14a Mon Sep 17 00:00:00 2001 From: Stephen Augustus Date: Mon, 25 Jan 2021 05:34:58 -0500 Subject: [PATCH 4/7] OWNERS(sig-release): Add CHANGELOG aliases Signed-off-by: Stephen Augustus --- CHANGELOG/OWNERS | 4 ++-- OWNERS_ALIASES | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG/OWNERS b/CHANGELOG/OWNERS index e6ea304a6fa..032f117b98b 100644 --- a/CHANGELOG/OWNERS +++ b/CHANGELOG/OWNERS @@ -1,9 +1,9 @@ # See the OWNERS docs at https://go.k8s.io/owners approvers: - - release-engineering-approvers + - changelog-approvers reviewers: - - release-engineering-reviewers + - changelog-reviewers labels: - sig/release diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 5107ce919ba..444a553d7f5 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -153,6 +153,8 @@ aliases: - puerco # Release Manager - saschagrunert # Release Manager / SIG Chair - xmudrii # Release Manager + changelog-approvers: + changelog-reviewers: sig-storage-approvers: - saad-ali From d7c6274d2fd522c06fb68d567dd7b161661ee2f5 Mon Sep 17 00:00:00 2001 From: hasheddan Date: Wed, 13 Jan 2021 09:08:58 -0600 Subject: [PATCH 5/7] OWNERS(CHANGELOG): Add wilsonehusin (1.21 relnotes lead) as approver Signed-off-by: hasheddan Co-authored-by: Stephen Augustus --- OWNERS_ALIASES | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 444a553d7f5..3ae79fe7267 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -154,7 +154,9 @@ aliases: - saschagrunert # Release Manager / SIG Chair - xmudrii # Release Manager changelog-approvers: + - wilsonehusin # 1.21 Release Notes Lead changelog-reviewers: + - wilsonehusin # 1.21 Release Notes Lead sig-storage-approvers: - saad-ali From 30fccd6b44868a827afeb8cc7815d08fa6e2d7ea Mon Sep 17 00:00:00 2001 From: Stephen Augustus Date: Mon, 25 Jan 2021 05:46:42 -0500 Subject: [PATCH 6/7] OWNERS(CHANGELOG): Add release-engineering-reviewers as approvers Signed-off-by: Stephen Augustus --- OWNERS_ALIASES | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 3ae79fe7267..720249a7de4 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -155,6 +155,14 @@ aliases: - xmudrii # Release Manager changelog-approvers: - wilsonehusin # 1.21 Release Notes Lead + - cpanato # Release Manager + - feiskyer # Release Manager + - hasheddan # Release Manager / SIG Technical Lead + - idealhack # Release Manager + - justaugustus # Release Manager / SIG Chair + - puerco # Release Manager + - saschagrunert # Release Manager / SIG Chair + - xmudrii # Release Manager changelog-reviewers: - wilsonehusin # 1.21 Release Notes Lead From c181fcd1f33ce035a8ec7d4720bc5109f37b4948 Mon Sep 17 00:00:00 2001 From: Stephen Augustus Date: Mon, 25 Jan 2021 05:47:28 -0500 Subject: [PATCH 7/7] OWNERS(CHANGELOG): Add 1.21 Release Notes shadows as reviewers Signed-off-by: Stephen Augustus --- OWNERS_ALIASES | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 720249a7de4..9327dc67d0a 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -165,6 +165,12 @@ aliases: - xmudrii # Release Manager changelog-reviewers: - wilsonehusin # 1.21 Release Notes Lead + # TODO(wilsonehusin): uncomment once ashnehete is an org member + # https://github.com/kubernetes/kubernetes/pull/97700#issuecomment-766734702 + #- ashnehete # 1.21 Release Notes shadow + - melodychn # 1.21 Release Notes shadow + - pmmalinov01 # 1.21 Release Notes shadow + - soniasingla # 1.21 Release Notes shadow sig-storage-approvers: - saad-ali